Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPQEditor] Introduce VISQ data #1543

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[MPQEditor] Introduce VISQ data #1543

wants to merge 1 commit into from

Conversation

stamalakhov
Copy link
Contributor

@stamalakhov stamalakhov commented Apr 28, 2023 •
edited
Loading

This draft introduces usage VISQ data for the task of manual mixed precision quantization.

Basic editing:

MPQ_basic.mp4

Show/Hide:

MPQ_show_hide.mp4

CancelScrollToSelection:

MPQ_cancelScrollToSelection.mp4

See attachment for sample circle model and computed visqs:
circle_model_and_visqs.zip

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov [email protected]

@stamalakhov stamalakhov self-assigned this Apr 28, 2023
This was referenced Apr 28, 2023
Merged
Merged
Merged
Merged
@stamalakhov stamalakhov force-pushed the manual_MPQ_visq_br branch 2 times, most recently from 116ca98 to 45cd713 Compare May 2, 2023 09:34
This was referenced May 2, 2023
Merged
Merged
@stamalakhov stamalakhov force-pushed the manual_MPQ_visq_br branch 2 times, most recently from a7d66ab to 8d976f8 Compare May 11, 2023 06:30
This was referenced May 11, 2023
Merged
Merged
@dayo09
Copy link
Contributor

dayo09 commented May 12, 2023

When I try to select a node, I need to click the operator name. By clicking the other parts of the operator node box, I cannot select the node. Do you intend it? Could you enable selection on any part of operation boxes?

@stamalakhov
Copy link
Contributor Author

When I try to select a node, I need to click the operator name. By clicking the other parts of the operator node box, I cannot select the node. Do you intend it? Could you enable selection on any part of operation boxes?

@dayo09
Thank you. I'll try.

@stamalakhov stamalakhov force-pushed the manual_MPQ_visq_br branch 3 times, most recently from 75921c1 to 9449c11 Compare May 12, 2023 08:57
@stamalakhov
Copy link
Contributor Author

@dayo09
It's fixed. Also there were issues with losing selection after changing nodes style by changing render mode of graph:
image
e.g. clicking 'Show Attributes' shows all specific nodes as deselected.
They are fixed also.

@stamalakhov stamalakhov force-pushed the manual_MPQ_visq_br branch from 9449c11 to d4f9777 Compare May 12, 2023 10:22
@stamalakhov
Copy link
Contributor Author

stamalakhov commented May 18, 2023 •
edited
Loading

@seanshpark
In Part-editor clicking middle of the box doesn't selects operator and choosing other regime deselects previous selection.
Is it intended?

simplescreenrecorder-2023-05-18_12.36.03.mp4

If it's not intended, then this draft fixes it, otherwise i'll have to introduce new mode, m.b. mpqselector.

@stamalakhov stamalakhov force-pushed the manual_MPQ_visq_br branch from d4f9777 to db77f65 Compare May 22, 2023 06:41
@stamalakhov stamalakhov mentioned this pull request May 22, 2023
Merged
@stamalakhov
[MPQEditor] Introduce VISQ data
c42aed9 
This draft introduces VISQ data.

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <[email protected]>
@stamalakhov stamalakhov force-pushed the manual_MPQ_visq_br branch from db77f65 to c42aed9 Compare May 24, 2023 07:32
@stamalakhov
Copy link
Contributor Author

@seanshpark
please take another look at #1543 (comment)
do i need to split code paths for PartEditor and MPQEditor ?

@seanshpark
Copy link
Contributor

In Part-editor clicking middle of the box doesn't selects operator and choosing other regime deselects previous selection.
Is it intended?

No, maybe UI bug.

do i need to split code paths for PartEditor and MPQEditor ?

I don't understand what you mean by "split"

@stamalakhov
Copy link
Contributor Author

I don't understand what you mean by "split"

I mean to introduce another viewing mode in circlegraph/view.js like it was done for visqselector. But if it's a bug, i'll provide PR that fixes it.

@seanshpark
Copy link
Contributor

But if it's a bug, i'll provide PR that fixes it.

Please do not try to fix this bug.

@stamalakhov
Copy link
Contributor Author

@seanshpark
Actually this draft fixes it.

@seanshpark
Copy link
Contributor

Actually this draft fixes it.

Anyway I do not want to accept changes as of now.

This was referenced May 26, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanshpark seanshpark Awaiting requested review from seanshpark

@dayo09 dayo09 Awaiting requested review from dayo09

At least 1 approving review is required to merge this pull request.

Assignees

@stamalakhov stamalakhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stamalakhov @dayo09 @seanshpark