[MPQEditor] Handle invalid VISQ data

[stamalakhov]

This commit implements handling of invalid VISQ file.

It's correctness is approved below:

simplescreenrecorder-2023-05-23_11.37.45.mp4

Fresh draft: #1543
Full draft: #1505
Related: #1491

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov [email protected]

[dayo09]

LGTM Thanks.
However, additionally, I think it would be better if
(1) non-visq files are unabled to be selected from the window initially.
(2) the circle viewer doesn't flick.

And I wonder what would happen if any non-visq file with *.visq.json postfix is selected.

[stamalakhov]

@dayo09 Thank you for your review.

non-visq files are unabled to be selected from the window initially.

By default selector is set to target files, which are *.visq.json.

And I wonder what would happen if any non-visq file with *.visq.json postfix is selected.

It will make sure that file doesn't contain error section or meta section, and will reboot in selector mode.
Please see

ONE-vscode/src/MPQEditor/MPQCircleSelector.ts

Line 253 in 1295a74

if (!("error" in this._visqData) || !("meta" in this._visqData)) {

[stamalakhov]

@dayo09

the circle viewer doesn't flick.

PR can be reworked. However it will be a large change.

[dayo09]

@stamalakhov I don't mind whether you proceed it in next PR or here. :-D

By default selector is set to target files, which are *.visq.json.

It will make sure that file doesn't contain error section or meta section, and will reboot in selector mode.
Please see

Oh sure. Those concerns are resolved then.

[stamalakhov]

@dayo09
I've reworked PR and also changed description (please see attached .mp4) . No flickering now.

[jyoungyun]

LGTM