Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPQEditor] Implement handleLoadVisqFile #1555

Merged
merged 3 commits into from
May 22, 2023

Conversation

stamalakhov
Copy link
Contributor

This commit implements processing of 'loadVisqFile' message and 'showVisqCircleModelGraph' function needed for that.

Its correctness is tested in #1543

Fresh draft: #1543
Full draft: #1505
Related: #1491

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov [email protected]

This commit implements processing of 'loadVisqFile' message and 'showVisqCircleModelGraph' function needed for that.

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <[email protected]>
@stamalakhov stamalakhov requested a review from dayo09 May 11, 2023 06:47
@stamalakhov stamalakhov self-assigned this May 11, 2023
@stamalakhov stamalakhov requested a review from jyoungyun May 11, 2023 06:49
jyoungyun
jyoungyun previously approved these changes May 11, 2023
Copy link
Collaborator

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/MPQEditor/MPQEditor.ts Outdated Show resolved Hide resolved
Apply suggestions from code review.

Co-authored-by: Jiyoung Giuliana Yun <[email protected]>
jyoungyun
jyoungyun previously approved these changes May 11, 2023
Copy link
Collaborator

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Apply suggestions from code review.

Co-authored-by: Dayoung Lee <[email protected]>

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <[email protected]>
@stamalakhov stamalakhov force-pushed the manual_MPQ_load_visq_br branch from f23dcb9 to 102ae07 Compare May 12, 2023 05:25
@stamalakhov stamalakhov requested review from jyoungyun and dayo09 May 12, 2023 05:26
Copy link
Contributor

@dayo09 dayo09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

Copy link
Collaborator

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dayo09
Copy link
Contributor

dayo09 commented May 22, 2023

@Samsung/one-vscode_committers PTAL :-D

@seanshpark seanshpark merged commit 1295a74 into Samsung:main May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants