-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPQEditor] Implement handleLoadVisqFile
#1555
Conversation
This commit implements processing of 'loadVisqFile' message and 'showVisqCircleModelGraph' function needed for that. ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Apply suggestions from code review. Co-authored-by: Jiyoung Giuliana Yun <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b07e7b8
to
f23dcb9
Compare
Apply suggestions from code review. Co-authored-by: Dayoung Lee <[email protected]> ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <[email protected]>
f23dcb9
to
102ae07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Samsung/one-vscode_committers PTAL :-D |
This commit implements processing of 'loadVisqFile' message and 'showVisqCircleModelGraph' function needed for that.
Its correctness is tested in #1543
Fresh draft: #1543
Full draft: #1505
Related: #1491
ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov [email protected]