Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPQEditor] Implement media for VISQ #1544

Merged
merged 1 commit into from
May 2, 2023

Conversation

stamalakhov
Copy link
Contributor

@stamalakhov stamalakhov commented Apr 28, 2023

This commit implements mpqeditor media changes for showing VISQ data for MPQ.

Its correctness is tested in #1543

Fresh draft: #1543
Full draft: #1505
Related: #1491

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov [email protected]

@stamalakhov stamalakhov self-assigned this Apr 28, 2023
@stamalakhov stamalakhov force-pushed the manual_MPQ_this_med_br branch from 04a174c to 48185d0 Compare April 28, 2023 12:51
This commit implements mpqeditor media changes for showing VISQ data for MPQ.

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <[email protected]>
@stamalakhov stamalakhov force-pushed the manual_MPQ_this_med_br branch from 48185d0 to 55736be Compare April 28, 2023 15:23
@dayo09
Copy link
Contributor

dayo09 commented May 2, 2023

Q. Could you add a sample visq.json file? I mean it doesn't have to be in this PR but it's just for reviewer's sake.

@stamalakhov
Copy link
Contributor Author

Q. Could you add a sample visq.json file? I mean it doesn't have to be in this PR but it's just for reviewer's sake.

@dayo09
Ahh. Sorry. Added samples to the draft. Please see: #1543 (comment)

Copy link
Contributor

@dayo09 dayo09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-D

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit 8600429 into Samsung:main May 2, 2023
@stamalakhov stamalakhov deleted the manual_MPQ_this_med_br branch May 2, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants