[MPQEditor] Implement 'cancelScrollToSelected' #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements 'cancelScrollToSelected' and uses it to prevent the view from scrolling after every user selection. ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <[email protected]>
stamalakhov
force-pushed
the
manual_MPQ_cancel_scroll_br
branch
from
e68957d to
8e6ef85
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
dayo09
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements 'cancelScrollToSelected' and uses it to prevent the view from scrolling after every user selection.
See related #1505 (comment).
Its correctness is tested in #1543
Fresh draft: #1543
Full draft: #1505
Related: #1491
ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov [email protected]