[CircleGraph] Introduce 'scrollToSelected' message #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces 'scrollToSelected' message. ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <[email protected]>
stamalakhov
force-pushed
the
manual_MPQ_visq_intro_mes_br
branch
from
d5cf68b to
b54272a
Compare
stamalakhov
changed the title
dayo09
approved these changes
May 2, 2023
seanshpark
reviewed
May 2, 2023
| @@ -55,6 +55,7 @@ export class MessageDefs { | |||
| public static readonly backendColor = "backendColor"; | |||
| public static readonly error = "error"; | |||
| public static readonly colorTheme = "colorTheme"; | |||
| public static readonly scrollToSelected = "scrollToSelected"; | |||
There was a problem hiding this comment.
I cannot accept this change and with related changes from the draft.
I need to test other modules with your change in the draft but cannot do the test as I am busy with other works and I cannot say when.
If possible, please do not fix this module but fix your codes.
If not, please post a new issue what you want, what the problem is with current codes.
There was a problem hiding this comment.
@seanshpark
I see. Thank you. ok.
There was a problem hiding this comment.
I've reviewed your draft code and there's no modification to existing features so I think it's OK to land the change.
There was a problem hiding this comment.
Ahh. ok. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces 'scrollToSelected' message.
Its correctness is tested in #1543
Fresh draft: #1543
Full draft: #1505
Related: #1491
ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov [email protected]