-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Miner] feat: add TxClient
#94
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
bryanchriswhite
force-pushed
the
feat/block-client
branch
from
October 24, 2023 14:44
596a49d
to
c72f94c
Compare
bryanchriswhite
force-pushed
the
feat/tx-client
branch
from
October 24, 2023 14:44
f5f26b6
to
b4981cb
Compare
bryanchriswhite
force-pushed
the
feat/block-client
branch
from
October 24, 2023 15:20
c72f94c
to
6fd863e
Compare
bryanchriswhite
force-pushed
the
feat/tx-client
branch
from
October 24, 2023 15:20
b4981cb
to
cb8ad96
Compare
bryanchriswhite
force-pushed
the
feat/block-client
branch
from
October 25, 2023 11:50
6fd863e
to
3ce04bf
Compare
bryanchriswhite
force-pushed
the
feat/tx-client
branch
from
October 25, 2023 11:50
cb8ad96
to
8d9063a
Compare
bryanchriswhite
force-pushed
the
feat/block-client
branch
from
October 25, 2023 12:16
3ce04bf
to
5cba456
Compare
bryanchriswhite
force-pushed
the
feat/tx-client
branch
from
October 25, 2023 12:16
8d9063a
to
2a3db50
Compare
bryanchriswhite
force-pushed
the
feat/block-client
branch
from
October 25, 2023 12:20
5cba456
to
9955dbb
Compare
bryanchriswhite
force-pushed
the
feat/tx-client
branch
2 times, most recently
from
October 25, 2023 13:00
c4de955
to
3f7cb13
Compare
This was referenced Oct 26, 2023
bryanchriswhite
force-pushed
the
feat/tx-client
branch
2 times, most recently
from
October 30, 2023 22:13
3867526
to
9d5b3a6
Compare
bryanchriswhite
changed the base branch from
feat/block-client
to
merge/block-client_x_retry
October 30, 2023 22:21
This was referenced Oct 30, 2023
bryanchriswhite
changed the title
[Miner] feat: add
[Miner] feat: add Oct 31, 2023
TxClient
& TxContext
TxClient
bryanchriswhite
force-pushed
the
feat/tx-client
branch
from
October 31, 2023 07:35
9d5b3a6
to
7ee554a
Compare
bryanchriswhite
changed the base branch from
merge/block-client_x_retry
to
merge/block-client_x_retry_x_tx-ctx
October 31, 2023 07:36
10 tasks
bryanchriswhite
force-pushed
the
feat/tx-client
branch
2 times, most recently
from
November 2, 2023 11:57
78184e5
to
61185e1
Compare
bryanchriswhite
changed the base branch from
merge/block-client_x_retry_x_tx-ctx
to
main
November 2, 2023 11:58
bryanchriswhite
force-pushed
the
feat/tx-client
branch
from
November 2, 2023 12:24
61185e1
to
cb23928
Compare
Olshansk
reviewed
Nov 3, 2023
bryanchriswhite
force-pushed
the
feat/tx-client
branch
from
November 3, 2023 20:38
7f462fd
to
833968c
Compare
10 tasks
@bryanchriswhite Checking in whether this is ready for another review yet or not? |
Olshansk
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty so much for simplifying the comments!
Co-authored-by: Daniel Olshansky <[email protected]>
bryanchriswhite
force-pushed
the
feat/tx-client
branch
from
November 7, 2023 07:53
3d6473b
to
baca6ef
Compare
bryanchriswhite
added a commit
that referenced
this pull request
Nov 7, 2023
…plementation * pokt/main: (28 commits) [Miner] feat: add supplier client (#42) [Off-chain] refactor: keyring errors & helpers (#131) [Miner] feat: add `TxClient` (#94) [CI] Build container images (#107) fix: flaky block client test (#132) [Tooling] add `go_lint` & `go_imports` make targets & CI step (#129) Update README.md [Code Health] Support `godoc` by replacing the `pocket `module name with `github.com/pokt-network/poktroll` (#128) [Miner] feat: add `TxContext` (#118) [Testing] fix: flaky tests in observable & client pkgs (#124) Added first roadmap change [AppGate] Implement UndelegateFromGateway with Extensive Tests (#125) [Miner] feat: add block client (#65) [Supplier] Add `ServiceConfigs` to `SupplierStaking` (#114) [AppGate] Add the MaxDelegatedGateways parameter (#109) [Test] Temporarily skip a flaky test `TestEventsQueryClient_Subscribe_Succeeds` (#121) [AppGate] Implement DelegateToGateway and add Tests (#90) [E2E] Add (Un)Stake Tests (#88) refactor: add `either.Bytes` alias (#117) feat: add either.AsyncErr type & helpers (#115) ...
Olshansk
added a commit
that referenced
this pull request
Nov 7, 2023
* chore: add `TxClient` interface * chore: add option support to `ReplayObservable` * feat: add `txClient` implementation * test: `txClient` * test: tx client integration * chore: s/tx/transaction/g * chore: update pkg README.md template * wip: client pkg README * docs: fix client pkg godoc comment * fix: flakey test * chore: dial back godoc comments 😅 * chore: revise (and move to godoc.go) `testblock` & `testeventsquery` pkg godoc comment * chore: update go.mod * chore: refactor & condense godoc comments * chore: fix import paths post-update * chore: review feedback improvements * docs: update client README.md * docs: add `tx query` usage association between `txContext` & `Blockchain` * docs: add TOC * chore: review feedback improvements Co-authored-by: Daniel Olshansky <[email protected]> * docs: improve godoc comments & client README.md --------- Co-authored-by: Daniel Olshansky <[email protected]>
Olshansk
added a commit
that referenced
this pull request
Nov 7, 2023
* chore: add `TxClient` interface * chore: add option support to `ReplayObservable` * feat: add `txClient` implementation * test: `txClient` * test: tx client integration * chore: s/tx/transaction/g * chore: update pkg README.md template * wip: client pkg README * docs: fix client pkg godoc comment * fix: flakey test * chore: dial back godoc comments 😅 * chore: revise (and move to godoc.go) `testblock` & `testeventsquery` pkg godoc comment * chore: update go.mod * chore: refactor & condense godoc comments * chore: fix import paths post-update * chore: review feedback improvements * docs: update client README.md * docs: add `tx query` usage association between `txContext` & `Blockchain` * docs: add TOC * chore: review feedback improvements Co-authored-by: Daniel Olshansky <[email protected]> * docs: improve godoc comments & client README.md --------- Co-authored-by: Daniel Olshansky <[email protected]>
Olshansk
added a commit
that referenced
this pull request
Nov 7, 2023
* chore: add `TxClient` interface * chore: add option support to `ReplayObservable` * feat: add `txClient` implementation * test: `txClient` * test: tx client integration * chore: s/tx/transaction/g * chore: update pkg README.md template * wip: client pkg README * docs: fix client pkg godoc comment * fix: flakey test * chore: dial back godoc comments 😅 * chore: revise (and move to godoc.go) `testblock` & `testeventsquery` pkg godoc comment * chore: update go.mod * chore: refactor & condense godoc comments * chore: fix import paths post-update * chore: review feedback improvements * docs: update client README.md * docs: add `tx query` usage association between `txContext` & `Blockchain` * docs: add TOC * chore: review feedback improvements Co-authored-by: Daniel Olshansky <[email protected]> * docs: improve godoc comments & client README.md --------- Co-authored-by: Daniel Olshansky <[email protected]>
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
* chore: add `TxClient` interface * chore: add option support to `ReplayObservable` * feat: add `txClient` implementation * test: `txClient` * test: tx client integration * chore: s/tx/transaction/g * chore: update pkg README.md template * wip: client pkg README * docs: fix client pkg godoc comment * fix: flakey test * chore: dial back godoc comments 😅 * chore: revise (and move to godoc.go) `testblock` & `testeventsquery` pkg godoc comment * chore: update go.mod * chore: refactor & condense godoc comments * chore: fix import paths post-update * chore: review feedback improvements * docs: update client README.md * docs: add `tx query` usage association between `txContext` & `Blockchain` * docs: add TOC * chore: review feedback improvements Co-authored-by: Daniel Olshansky <[email protected]> * docs: improve godoc comments & client README.md --------- Co-authored-by: Daniel Olshansky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Human Summary
AI Summary
Summary generated by Reviewpad on 07 Nov 23 07:56 UTC
This pull request includes several changes across multiple files.
A new file
godoc.go
has been added to thepkg/client
directory. This file defines a package calledclient
that provides interfaces and types for interacting with blockchain functionalities.The
go.mod
file has been modified to update dependencies and remove unused dependencies.A new file
services.go
has been added to thepkg/client
package. This file contains a functionNewTestApplicationServiceConfig
that returns a slice of pointers tosharedtypes.ApplicationServiceConfig
structs.The
context.go
file has been modified to update comments and function names related to the cosmos-sdk transaction handling.A new file
README.md
has been added, which provides an overview of theclient
package, installation instructions, usage examples, and other sections.The
errors.go
file has been added to thepkg/client/tx
package. It defines error variables related to transaction handling.The
README.md
file has been modified to remove certain sections.Several files have been modified or added to the
pkg/client/tx
package, including the addition of a new mock client for theBlockClient
interface and changes to theTxClient
andTxContext
interfaces.The
go.sum
file has been updated to include changes to the versions of certain dependencies.Files related to test client functionality have been modified or added.
Overall, this pull request includes various additions, modifications, and updates across multiple files to enhance the functionality and documentation of the codebase.
Issue
Relates to:
TxClient
&TxContext
are used to build, encode, sign, and broadcast transactions from an off-chain context.Type of change
Select one or more:
Testing
make go_test
Sanity Checklist