-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Miner] feat: add supplier client #42
Conversation
493f900
to
40f1c69
Compare
40f1c69
to
315754d
Compare
315754d
to
1d7386b
Compare
bcf7004
to
9892a5b
Compare
5cba456
to
9955dbb
Compare
9d5b3a6
to
7ee554a
Compare
78184e5
to
61185e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bryanchriswhite You mentioned some changes are being shown / not shown which is a result of merge/base branch issues.
Going to hold off until that's resolved to avoid review overhead.
https://github.com/pokt-network/poktroll/pull/42/files#r1382188801
* feat/tx-client: chore: fix import paths post-update chore: refactor & condense godoc comments chore: update go.mod chore: revise (and move to godoc.go) `testblock` & `testeventsquery` pkg godoc comment [Tooling] add `go_lint` & `go_imports` make targets & CI step (#129) Update README.md [Code Health] Support `godoc` by replacing the `pocket `module name with `github.com/pokt-network/poktroll` (#128)
* refactor/keyring-errors-helpers: chore: fix import paths post-update chore: refactor & condense godoc comments chore: update go.mod chore: revise (and move to godoc.go) `testblock` & `testeventsquery` pkg godoc comment [Tooling] add `go_lint` & `go_imports` make targets & CI step (#129) Update README.md [Code Health] Support `godoc` by replacing the `pocket `module name with `github.com/pokt-network/poktroll` (#128)
This was definitely GitHub doing the wrong thing, I triple checked. The bizarre behavior nearly coincided with some service interruptions they experienced recently; perhaps there is a causal connection there. After poking it today, it seems to have decided to do the right thing. |
…plementation * pokt/main: (28 commits) [Miner] feat: add supplier client (#42) [Off-chain] refactor: keyring errors & helpers (#131) [Miner] feat: add `TxClient` (#94) [CI] Build container images (#107) fix: flaky block client test (#132) [Tooling] add `go_lint` & `go_imports` make targets & CI step (#129) Update README.md [Code Health] Support `godoc` by replacing the `pocket `module name with `github.com/pokt-network/poktroll` (#128) [Miner] feat: add `TxContext` (#118) [Testing] fix: flaky tests in observable & client pkgs (#124) Added first roadmap change [AppGate] Implement UndelegateFromGateway with Extensive Tests (#125) [Miner] feat: add block client (#65) [Supplier] Add `ServiceConfigs` to `SupplierStaking` (#114) [AppGate] Add the MaxDelegatedGateways parameter (#109) [Test] Temporarily skip a flaky test `TestEventsQueryClient_Subscribe_Succeeds` (#121) [AppGate] Implement DelegateToGateway and add Tests (#90) [E2E] Add (Un)Stake Tests (#88) refactor: add `either.Bytes` alias (#117) feat: add either.AsyncErr type & helpers (#115) ...
* chore: add `TxClient` interface * chore: add option support to `ReplayObservable` * feat: add `txClient` implementation * test: `txClient` * test: tx client integration * chore: s/tx/transaction/g * chore: update pkg README.md template * wip: client pkg README * docs: fix client pkg godoc comment * refactor: consolidate keyring errors & helpers * refactor: keyring test helpers * fix: flakey test * chore: dial back godoc comments 😅 * chore: add `SupplierClient` interface * feat: add supplier client implementation * test: supplier test helpers * test: supplier client tests * test: supplier client integration test * chore: update go.mod * trigger CI * chore: revise (and move to godoc.go) `testblock` & `testeventsquery` pkg godoc comment * chore: update go.mod * chore: refactor & condense godoc comments * chore: fix import paths post-update * chore: add godoc comment
* chore: add `TxClient` interface * chore: add option support to `ReplayObservable` * feat: add `txClient` implementation * test: `txClient` * test: tx client integration * chore: s/tx/transaction/g * chore: update pkg README.md template * wip: client pkg README * docs: fix client pkg godoc comment * refactor: consolidate keyring errors & helpers * refactor: keyring test helpers * fix: flakey test * chore: dial back godoc comments 😅 * chore: add `SupplierClient` interface * feat: add supplier client implementation * test: supplier test helpers * test: supplier client tests * test: supplier client integration test * chore: update go.mod * trigger CI * chore: revise (and move to godoc.go) `testblock` & `testeventsquery` pkg godoc comment * chore: update go.mod * chore: refactor & condense godoc comments * chore: fix import paths post-update * chore: add godoc comment
* chore: add `TxClient` interface * chore: add option support to `ReplayObservable` * feat: add `txClient` implementation * test: `txClient` * test: tx client integration * chore: s/tx/transaction/g * chore: update pkg README.md template * wip: client pkg README * docs: fix client pkg godoc comment * refactor: consolidate keyring errors & helpers * refactor: keyring test helpers * fix: flakey test * chore: dial back godoc comments 😅 * chore: add `SupplierClient` interface * feat: add supplier client implementation * test: supplier test helpers * test: supplier client tests * test: supplier client integration test * chore: update go.mod * trigger CI * chore: revise (and move to godoc.go) `testblock` & `testeventsquery` pkg godoc comment * chore: update go.mod * chore: refactor & condense godoc comments * chore: fix import paths post-update * chore: add godoc comment
* chore: add `TxClient` interface * chore: add option support to `ReplayObservable` * feat: add `txClient` implementation * test: `txClient` * test: tx client integration * chore: s/tx/transaction/g * chore: update pkg README.md template * wip: client pkg README * docs: fix client pkg godoc comment * refactor: consolidate keyring errors & helpers * refactor: keyring test helpers * fix: flakey test * chore: dial back godoc comments 😅 * chore: add `SupplierClient` interface * feat: add supplier client implementation * test: supplier test helpers * test: supplier client tests * test: supplier client integration test * chore: update go.mod * trigger CI * chore: revise (and move to godoc.go) `testblock` & `testeventsquery` pkg godoc comment * chore: update go.mod * chore: refactor & condense godoc comments * chore: fix import paths post-update * chore: add godoc comment
Summary
Human Summary
Adds
SupplierClient
interface, implementation, and unit tests.Summary generated by Reviewpad on 07 Nov 23 08:48 UTC
This pull request includes the following changes:
Added a new file named "client.go" in the "internal/testclient/testtx" package. It contains various functions and types related to creating and using a client for transaction testing.
Added a new file named "client_integration_test.go" in the "pkg/client/supplier" package. It contains an integration test for the "supplier" package.
Changes were made to the "interface.go" file, including the addition of new methods and renaming of an existing method in the "SupplierClient" and "BlockClient" interfaces.
Changes were made to the "context.go" file, including the addition of a new function and a comment indicating a TODO.
Added a new test file named "client_test.go" in the "pkg/client/supplier" package. It contains test functions for testing the "NewSupplierClient", "CreateClaim", and "SubmitProof" functions of the "supplier" package.
Added a new file named "options.go" in the "pkg/client/supplier" package. It defines a function named "WithSigningKeyName" that sets the "signingKeyName" field of the "supplierClient" struct.
Modifications were made to the "keyring.go" file in the "internal/testclient" package, including the addition of a new function.
Issue
Relates to:
SupplierClient
&BlockClient
are dependencies ofMiner
.Type of change
Select one or more:
Testing
make test_all_unit
Sanity Checklist