Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Miner] Foundation for the Miner submodule #13

Closed
1 of 10 tasks
Olshansk opened this issue Oct 5, 2023 · 5 comments · Fixed by #31, #43, #44, #64 or #65
Closed
1 of 10 tasks

[Miner] Foundation for the Miner submodule #13

Olshansk opened this issue Oct 5, 2023 · 5 comments · Fixed by #31, #43, #44, #64 or #65
Assignees
Labels
miner Changes related to the Miner off-chain Off-chain business logic

Comments

@Olshansk
Copy link
Member

Olshansk commented Oct 5, 2023

Objective

Create a foundation for the Miner submodule in the poktroll repo for the Shannon upgrade.

Origin Document

The business logic for mining relays from the Relay Mining paper.

Goals

  • Enable an E2E HTTP relay with basic session and account management
  • Build the foundation for the Miner submodule for the Relayer
  • Identify time-consuming TODOs to be done during the integration and testing stages

Deliverables

  • Reference structures and types in the poktroll-alpha repo, the v1 repo and v0 repo to understand and use other definitions as a foundation
  • A single PR that introduces the Miner structure & interface
  • A single PR that adds business logic, with the appropriate placeholders & TODOs, to add Miner functionality
  • A single PR that integrates the miner with other components (e.g. SessionManager, Proxy, Relayer, Client, etc...) to enable E2E functionality
  • A single PR that integrates with the SMT for proof validation & verification
  • Multiple small PRs that migrate the necessary utilities from the poktroll-alpha repo to the poktroll repo

Non-goals / Non-deliverables

  • WebSocket support (HTTP only is okay)
  • Accounting for all possible edge cases and situations

General deliverables

  • Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
  • Testing: Add new tests (unit and/or E2E) to the test suite.
  • Makefile: Add new targets to the Makefile to make the new functionality easier to use.
  • Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.

Creator: @Olshansk
Co-Owners: @bryanchriswhite @red-0ne

@Olshansk Olshansk added the miner Changes related to the Miner label Oct 5, 2023
@Olshansk Olshansk added this to the Shannon TestNet milestone Oct 5, 2023
@Olshansk Olshansk added this to Shannon Oct 5, 2023
@Olshansk Olshansk moved this to 🔖 Ready in Shannon Oct 5, 2023
@Olshansk Olshansk added the off-chain Off-chain business logic label Oct 6, 2023
@bryanchriswhite bryanchriswhite linked a pull request Oct 9, 2023 that will close this issue
10 tasks
@bryanchriswhite bryanchriswhite moved this from 🔖 Ready to 🏗 In progress in Shannon Oct 9, 2023
@bryanchriswhite bryanchriswhite linked a pull request Oct 10, 2023 that will close this issue
10 tasks
This was linked to pull requests Oct 14, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Shannon Oct 17, 2023
@Olshansk Olshansk reopened this Oct 17, 2023
@Olshansk
Copy link
Member Author

@bryanchriswhite Looking at the deliverables of this ticket, I would argue it is not complete yet.

@bryanchriswhite
Copy link
Contributor

@Olshansk agreed, thanks for re-opening. Are you aware of a way to prevent the issue from automatically closing when a linked PR is merged? Perhaps I should just not link them in the "development" section?

@Olshansk
Copy link
Member Author

re you aware of a way to prevent the issue from automatically closing when a linked PR is merged?

I am not. As far as I'm concerned, it's an open GitHub Issue:

Perhaps I should just not link them in the "development" section?

If you remember to reopen issues that aren't done, feel free to link to it. Otherwise, we can rely on mentions.

@bryanchriswhite bryanchriswhite moved this from ✅ Done to 🏗 In progress in Shannon Oct 18, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Shannon Oct 20, 2023
@bryanchriswhite
Copy link
Contributor

---
title: Clients Dependency Tree
---
flowchart

sup[SupplierClient]
tx[TxClient]
bl[BlockClient]
evt[EventsQueryClient]

sup --"#SignAndBroadcast()"--> tx
tx --"#CommittedBlocksSequence()"--> bl
tx --"#EventsBytes()"--> evt
bl --"#EventsBytes()"--> evt
Loading

@bryanchriswhite bryanchriswhite moved this from ✅ Done to 🏗 In progress in Shannon Oct 24, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Shannon Oct 27, 2023
@bryanchriswhite bryanchriswhite moved this from ✅ Done to 🏗 In progress in Shannon Oct 27, 2023
@bryanchriswhite bryanchriswhite removed a link to a pull request Oct 31, 2023
10 tasks
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Shannon Nov 1, 2023
@Olshansk Olshansk reopened this Nov 1, 2023
@Olshansk
Copy link
Member Author

Olshansk commented Nov 1, 2023

@bryanchriswhite I believe this was closed by accident, so I've reopened it.

Feel free to close if that was intentional.

@bryanchriswhite bryanchriswhite moved this from ✅ Done to 🏗 In progress in Shannon Nov 2, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Shannon Nov 7, 2023
@bryanchriswhite bryanchriswhite moved this from ✅ Done to 🏗 In progress in Shannon Nov 7, 2023
@bryanchriswhite bryanchriswhite linked a pull request Nov 7, 2023 that will close this issue
10 tasks
@bryanchriswhite bryanchriswhite linked a pull request Nov 9, 2023 that will close this issue
10 tasks
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Shannon Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment