[Either] refactor: add either.Bytes alias
#117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
added
miner
Olshansk
approved these changes
Oct 30, 2023
Olshansk
pushed a commit
that referenced
this pull request
Oct 31, 2023
bryanchriswhite
added a commit
that referenced
this pull request
Nov 7, 2023
…plementation * pokt/main: (28 commits) [Miner] feat: add supplier client (#42) [Off-chain] refactor: keyring errors & helpers (#131) [Miner] feat: add `TxClient` (#94) [CI] Build container images (#107) fix: flaky block client test (#132) [Tooling] add `go_lint` & `go_imports` make targets & CI step (#129) Update README.md [Code Health] Support `godoc` by replacing the `pocket `module name with `github.com/pokt-network/poktroll` (#128) [Miner] feat: add `TxContext` (#118) [Testing] fix: flaky tests in observable & client pkgs (#124) Added first roadmap change [AppGate] Implement UndelegateFromGateway with Extensive Tests (#125) [Miner] feat: add block client (#65) [Supplier] Add `ServiceConfigs` to `SupplierStaking` (#114) [AppGate] Add the MaxDelegatedGateways parameter (#109) [Test] Temporarily skip a flaky test `TestEventsQueryClient_Subscribe_Succeeds` (#121) [AppGate] Implement DelegateToGateway and add Tests (#90) [E2E] Add (Un)Stake Tests (#88) refactor: add `either.Bytes` alias (#117) feat: add either.AsyncErr type & helpers (#115) ...
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Human Summary
Quick refactoring of
either.Either[[]byte]toeither.Bytesfor improved readability & convenience.AI Summary
Summary generated by Reviewpad on 30 Oct 23 23:05 UTC
This pull request refactors the code by adding an alias
either.Bytes. The changes are made in thepkg/client/events_query/client.go,pkg/client/interface.go, andpkg/either/types.gofiles. TheeventsBytesfield in theeventsBytesAndConnstruct now receives aneither.Bytestype instead ofeither.Either[[]byte]. Similarly, theeventsBzObservableandeventsBzPublishChvariables in thenewEventsBytesAndConnfunction are changed toobservable.Observable[either.Bytes]andchannel.NewObservable[either.Bytes]()respectively. TheeventsBzPublishChparameter in thegoPublishEventsBzfunction is also changed tochan<- either.Bytes. Furthermore, in thepkg/client/interface.gofile, theEventsBytesObservabletype alias is now defined asobservable.Observable[either.Bytes]. Finally, in thepkg/either/types.gofile, theBytestype alias is created as a shorthand forEither[[]byte].Issue
Relates to:
TxClient#94Type of change
Select one or more:
Testing
make go_develop_and_testSanity Checklist