-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new index page for OLS #688
Conversation
Signed-off-by: NPDebs <[email protected]>
Signed-off-by: NPDebs <[email protected]>
Signed-off-by: NPDebs <[email protected]>
Signed-off-by: NPDebs <[email protected]>
Signed-off-by: NPDebs <[email protected]>
Signed-off-by: NPDebs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NPDebs. Here are some suggestions for changes
index.md
Outdated
image: /images/index.jpg | ||
photos: | ||
name: Bérénice Batut | ||
license: CC BY-SA 4.0 | ||
url: https://flic.kr/p/2gHMJah | ||
images: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand why putting the image paths in the metadata there and not just in the page content?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the former structure, these images would have been added multiple times across the page. So, rather than having the path repeating everywhere, I put them in the metadata.
We can do without it now, for sure.
open-incubator.md
Outdated
layout: default | ||
title: Open Incubator | ||
description: Hands-on support to empower the next generation of open leaders in research. | ||
image: /images/index.jpg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe another image there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same thought.
It would be nice to have different images in all the pages. I can do some samples for you to see.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go for sampling 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aye aye, captain. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey. I found some nice images in your Flickr account. Maybe you can let us borrow one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go for it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not represent research in my mind
You stole the words from my mouth. 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go for it :)
Yaay. 🎉 Thanks!
Now, I just have to download this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I think you're going to love it. I know I do! 😻
open-research.md
Outdated
Launch announcement: https://openlifesci.org/posts/2021/12/21/wt-open-research-fund/ | ||
|
||
#### Key personnel, impact research: | ||
Paz Bernaldo leads the qualitative interview study, and Malvika Sharan is PI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add below the people cards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty certain I replied this comment yesterday. Strange things are happening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had said:
Adding cards might look aesthetically pleasing. However, it might make it a little difficult for just anyone to contribute to this page. I would suggest that we link directly to their cards on the people page.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, it might make it a little difficult for just anyone to contribute to this page.
Do you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on how we intend to add the people cards, not everyone will be able to do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would you implement it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put the names in the page's metadata and loop through to display biocards at the bottom of the page.
That way, a new contributor just needs to add a name to the persons
array in the metadata.
Co-authored-by: Bérénice Batut <[email protected]>
Co-authored-by: Bérénice Batut <[email protected]>
Co-authored-by: Bérénice Batut <[email protected]>
Co-authored-by: Bérénice Batut <[email protected]>
Co-authored-by: Bérénice Batut <[email protected]>
Co-authored-by: Bérénice Batut <[email protected]>
Co-authored-by: Bérénice Batut <[email protected]>
Co-authored-by: Bérénice Batut <[email protected]>
Co-authored-by: Bérénice Batut <[email protected]>
Co-authored-by: Bérénice Batut <[email protected]>
Signed-off-by: NPDebs <[email protected]>
Signed-off-by: NPDebs <[email protected]>
Signed-off-by: NPDebs <[email protected]>
Signed-off-by: NPDebs <[email protected]>
open-science-training.md
Outdated
- Our programs are built with a global community of experienced community builders and open practitioners. | ||
|
||
# Current work streams: | ||
- [Open Seeds (16-weeks)]({% link openseeds/index.md %}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be 2 box there as for the index with the pillar with the logo and program name below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 That could work...and look really good.
I am thinking that for the sake of consistency, would we have to do the same for all 3 Pillars pages?
If yes, would the cards not be too much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say no for now for the other pages because different projects do not have dedicated pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I'll put them in boxes now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: NPDebs <[email protected]>
Signed-off-by: NPDebs <[email protected]>
Signed-off-by: NPDebs <[email protected]>
….github.io into OLS_index
I changed the implementation a bit. I moved the projects in the pillar pages as metadata and used an include file with loops to display them as cards and then below with details including people involved |
It looks great!! Thanks a lot @NPDebs |
This PR addresses issue #645.
As mentioned by Yo here, the content of the we-are-ols.org landing page was moved to the Open Seeds subsite. Thus, we needed to create new content.
Using the 3 Pillars created by Emmy (thank you!), Jilaga designed this lovely page (figma link).
Note for reviewers:
Thanks for the review!