Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new index page for OLS #688

Merged
merged 32 commits into from
Nov 21, 2023
Merged

Conversation

NPDebs
Copy link
Collaborator

@NPDebs NPDebs commented Oct 17, 2023

This PR addresses issue #645.

As mentioned by Yo here, the content of the we-are-ols.org landing page was moved to the Open Seeds subsite. Thus, we needed to create new content.

Using the 3 Pillars created by Emmy (thank you!), Jilaga designed this lovely page (figma link).

Screenshot (583)

Note for reviewers:

  • Icons are yet to be added to the page. They will be once these icons are uploaded to the branding repo.
  • I am not sure where to link these items to...
    • WT impact research
    • Turing Skills Policy Award
    • Resident fellows program
    • Online call facilitators training and transcription services

Thanks for the review!

@NPDebs NPDebs marked this pull request as ready for review November 13, 2023 10:55
Copy link
Member

@bebatut bebatut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NPDebs. Here are some suggestions for changes

index.md Outdated
image: /images/index.jpg
photos:
name: Bérénice Batut
license: CC BY-SA 4.0
url: https://flic.kr/p/2gHMJah
images:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand why putting the image paths in the metadata there and not just in the page content?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the former structure, these images would have been added multiple times across the page. So, rather than having the path repeating everywhere, I put them in the metadata.

We can do without it now, for sure.

open-research.md Outdated Show resolved Hide resolved
open-incubator.md Outdated Show resolved Hide resolved
open-incubator.md Outdated Show resolved Hide resolved
layout: default
title: Open Incubator
description: Hands-on support to empower the next generation of open leaders in research.
image: /images/index.jpg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe another image there

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same thought.
It would be nice to have different images in all the pages. I can do some samples for you to see.

What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for sampling 😄

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye aye, captain. 😄

Copy link
Collaborator Author

@NPDebs NPDebs Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bérénice, I just had a bit of an epiphany. 😃

So, at first I found these images:

But I thought, hmmmm...we already have images in this site that capture the essence of the 3 pillars.

E.g:
Screenshot (595)

Screenshot (596)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. I found some nice images in your Flickr account. Maybe you can let us borrow one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go for it :)

Copy link
Collaborator Author

@NPDebs NPDebs Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not represent research in my mind

You stole the words from my mouth. 💯

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go for it :)

Yaay. 🎉 Thanks!
Now, I just have to download this one.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I think you're going to love it. I know I do! 😻

open-research.md Outdated Show resolved Hide resolved
open-research.md Outdated Show resolved Hide resolved
open-research.md Outdated
Launch announcement: https://openlifesci.org/posts/2021/12/21/wt-open-research-fund/

#### Key personnel, impact research:
Paz Bernaldo leads the qualitative interview study, and Malvika Sharan is PI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add below the people cards

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty certain I replied this comment yesterday. Strange things are happening.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had said:

Adding cards might look aesthetically pleasing. However, it might make it a little difficult for just anyone to contribute to this page. I would suggest that we link directly to their cards on the people page.

What do you think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this...

Screenshot (599)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, it might make it a little difficult for just anyone to contribute to this page.

Do you mean?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on how we intend to add the people cards, not everyone will be able to do it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you implement it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the names in the page's metadata and loop through to display biocards at the bottom of the page.
That way, a new contributor just needs to add a name to the persons array in the metadata.

open-research.md Outdated Show resolved Hide resolved
open-science-training.md Outdated Show resolved Hide resolved
- Our programs are built with a global community of experienced community builders and open practitioners.

# Current work streams:
- [Open Seeds (16-weeks)]({% link openseeds/index.md %})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be 2 box there as for the index with the pillar with the logo and program name below

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 That could work...and look really good.

I am thinking that for the sake of consistency, would we have to do the same for all 3 Pillars pages?
If yes, would the cards not be too much.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say no for now for the other pages because different projects do not have dedicated pages

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I'll put them in boxes now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Here, the Open Seeds logo looked deformed with the class="image is-128x128".
Screenshot (600)

Without the class, it looks like this:
Screenshot (601)

@bebatut
Copy link
Member

bebatut commented Nov 21, 2023

I changed the implementation a bit. I moved the projects in the pillar pages as metadata and used an include file with loops to display them as cards and then below with details including people involved
It renders like this: https://deploy-preview-688--ols-bebatut.netlify.app/open-research

@bebatut
Copy link
Member

bebatut commented Nov 21, 2023

It looks great!! Thanks a lot @NPDebs

@bebatut bebatut merged commit 001fc68 into open-life-science:main Nov 21, 2023
6 of 9 checks passed
@NPDebs NPDebs deleted the OLS_index branch July 24, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants