Implement conditional navbar for pages #694
Conversation
Signed-off-by: NPDebs <[email protected]>
Signed-off-by: NPDebs <[email protected]>
Signed-off-by: NPDebs <[email protected]>
Signed-off-by: NPDebs <[email protected]>
_includes/openseeds-header.html
Outdated
| <a class="navbar-item" href="{% link about.md %}#mentors"> Mentors </a> | ||
| <a class="navbar-item" href="{% link about.md %}#experts"> Experts </a> | ||
| <a class="navbar-item" href="{% link about.md %}#facilitators"> Facilitators </a> | ||
| <a class="navbar-item navbar-previous-title" href="{% link openseeds/index.md %}#cohorts"> Cohorts </a> |
There was a problem hiding this comment.
This could be maybe moved as a dedicated dropdown menu, linking then to the different cohorts
There was a problem hiding this comment.
I hope I understood this and executed it correctly. I will leave the comment unresolved, just in case 😄
| @@ -45,7 +45,7 @@ | |||
| </div> | |||
There was a problem hiding this comment.
It might be good to modify the navbar above.
OLS-8 should be maybe removed. We could also then have a menu for each of the 3 pillars
There was a problem hiding this comment.
Definitely! I have just added a new navbar dropdown that contains our 3 pillars.
Since this captures the consulting service as well (under open incubator), I think we can remove the Services navbar-link. What do you think?
Signed-off-by: NPDebs <[email protected]>
Signed-off-by: NPDebs <[email protected]>
Signed-off-by: NPDebs <[email protected]>
Signed-off-by: NPDebs <[email protected]>
Signed-off-by: NPDebs <[email protected]>
_includes/default-header.html
Outdated
| <a class="navbar-item" href="#">WT impact research</a> | ||
| <a class="navbar-item" href="#">Turing Skills Policy Award</a> | ||
| <a class="navbar-item navbar-previous-title" href="#">Open Incubator</a> | ||
| <a class="navbar-item" href="#">Resident fellows program</a> |
There was a problem hiding this comment.
There is no section in the open-incubator.md file to link to that
There was a problem hiding this comment.
About that...
You're right. The individual pages for the 3 Pillars still need more content. You may have noticed in PR #688 that only open-research.md seems fully developed. The other two? Not so much.
I think Yo is in the process of writing the content to be added.
Until we can get more information added to open-incubator.md, we probably have two options:
- Merge this PR as is (considering all that is left is what Yo will give us).
- Wait for PR 688 to be complete, and link appropriately before merging this.
What do you think?
There was a problem hiding this comment.
P.S. The tests are failing because we don't have the open.research.md, etc mentioned in the navbar. It should be fine once the other PR is ready (or we can remove the links and use # for now).
Basically, no cause for alarm. 😄
There was a problem hiding this comment.
I would wait to merge this PR than the other one is merged so everything could be fixed and in place
Co-authored-by: Bérénice Batut <[email protected]>
Co-authored-by: Bérénice Batut <[email protected]>
Co-authored-by: Bérénice Batut <[email protected]>
Co-authored-by: Bérénice Batut <[email protected]>
Co-authored-by: Bérénice Batut <[email protected]>
Co-authored-by: Bérénice Batut <[email protected]>
Co-authored-by: Bérénice Batut <[email protected]>
|
Thanks a lot for the suggestions you made. The PR definitely looks richer! 💯🌟 |
bebatut
force-pushed
the
conditional_nav
branch
from
8574614 to
f6fb150
Compare
|
Thanks a lot @NPDebs !!!! |
This PR addresses issue #649.
With the newly created /openseeds subsite, there is a need to display a navbar with a different look and content.
Thus, the changes made in this PR were:
openseeds-navbar.html),index.htmllayout that displays a navbar depending on which url is requested.Note for reviewer(s):
The both navbars look the same for now because we are in the process of:
Thanks for taking the time to review!