Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-uniquify hierarchical blocks in genus for hierarchical flows #812

Merged
merged 4 commits into from
Oct 23, 2023
Merged

De-uniquify hierarchical blocks in genus for hierarchical flows #812

merged 4 commits into from
Oct 23, 2023

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented Oct 22, 2023 •
edited
Loading

With DDI, syn_generic uniquifies ILM module names. Prevent this by deuniquifying after syn_generic.

This also assumes that the type of hierarchical instances appears as hierarchical in the placement constraints.
Evidently this wasn't required before for the hierarchical flow to work correctly, but it is required for this fix to work.

Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

@jerryz123 jerryz123 marked this pull request as ready for review October 22, 2023 20:41
harrisonliew
harrisonliew approved these changes Oct 22, 2023
View reviewed changes
Copy link
Contributor

@harrisonliew harrisonliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be prudent to run the final top netlist thru LEC to show that this change_link is correct.

@harrisonliew harrisonliew added this pull request to the merge queue Oct 23, 2023
Merged via the queue into master with commit 3587e67 Oct 23, 2023
@harrisonliew harrisonliew deleted the ununiq_genus branch October 23, 2023 00:30
nayiri-k pushed a commit that referenced this pull request Nov 13, 2023
@jerryz123 @nayiri-k
De-uniquify hierarchical blocks in genus for hierarchical flows (#812)
62941d5 
* De-uniquify hierarchical blocks in genus for hierarchical flows

With DDI, syn_generic uniquifies ILM module names. Prevent this by
deuniquifying after syn_generic.��

* Only de-uniquify for DDI versions >= 211

* Add warning messages when de-uniquifying in genus

* change_link should copy_attributes of the uniquified instance
@jerryz123 jerryz123 mentioned this pull request Nov 17, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrisonliew harrisonliew harrisonliew approved these changes

@kenhoberkeley kenhoberkeley Awaiting requested review from kenhoberkeley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerryz123 @harrisonliew