Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to dedup ILMs after both syn_map and syn_generic #826

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

jerryz123
Copy link
Contributor

Previously, #812 only dedups after syn_generic, but I found that sometimes, syn_map will also unnessarily uniquify ILMs. This adds the dedup_ilm step after both syn_generic and syn_map.

Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

Copy link
Contributor

@harrisonliew harrisonliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a need to create new steps for these... just tack a common method (dedup_ilms) inside (at the end) of each of the two existing steps?

@harrisonliew harrisonliew added this pull request to the merge queue Nov 19, 2023
Merged via the queue into master with commit c844244 Nov 19, 2023
3 checks passed
@harrisonliew harrisonliew deleted the ilm_dedup branch November 19, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants