Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support message type autoware_internal_planning_msgs::msg::PathWithLaneId #1518

Merged
merged 10 commits into from
Feb 6, 2025

Conversation

yamacir-kit
Copy link
Collaborator

@yamacir-kit yamacir-kit commented Jan 28, 2025

Description

Abstract

Support message type autoware_internal_planning_msgs::msg::PathWithLaneId.

Background

From Pilot.Auto 0.41.0, autoware_internal_planning_msgs has been added. Due to the addition of this message type, tier4_planning_msgs::msg::PathWithLaneId will be replaced by autoware_internal_planning_msgs::msg::PathWithLaneId from Pilot.Auto 0.41.1 onwards. In other words, Pilot.Auto 0.41.0 is a version to give time for the message type change, and while tier4_planning_msgs::msg::PathWithLaneId and autoware_internal_planning_msgs::msg::PathWithLaneId coexist, tier4_planning_msgs::msg::PathWithLaneId is the one that is used.

To accommodate this change, scenario_simulator_v2 needs to support both message types and be able to switch which one to use. This pull request does this.

Details

The current default architecture_type is awf/unvierse/20240605 and this pull request does not change it. (We need to consider how to manage the default architecture_type in the future.)

  • If architecture_type is awf/universe/20250130 or later, autoware_internal_planning_msgs::msg::PathWithLaneId subscribers are instantiated.
  • Otherwise, tier4_planning_msgs::msg::PathWithLaneId subscribers are instantiated.

To achieve the above switch, the class template Subscriber has been updated, and some auxiliary class templates have been added for it.

References

None.

Destructive Changes

None.

Known Limitations

None.

@yamacir-kit yamacir-kit added feature New feature or request bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 labels Jan 28, 2025
@yamacir-kit yamacir-kit self-assigned this Jan 28, 2025
Copy link

github-actions bot commented Jan 28, 2025

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@mitsudome-r
Copy link
Contributor

NOTE: This PR is waiting for Autoware's release on 0.41.0

@yamacir-kit yamacir-kit requested a review from HansRobo January 29, 2025 09:01
@yamacir-kit yamacir-kit marked this pull request as ready for review February 5, 2025 02:40
@yamacir-kit yamacir-kit merged commit 7030ce1 into master Feb 6, 2025
16 checks passed
@github-actions github-actions bot deleted the feature/support-latest-autoware-message-type branch February 6, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 feature New feature or request wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants