-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support message type autoware_internal_planning_msgs::msg::PathWithLaneId
#1518
Merged
yamacir-kit
merged 10 commits into
master
from
feature/support-latest-autoware-message-type
Feb 6, 2025
Merged
Support message type autoware_internal_planning_msgs::msg::PathWithLaneId
#1518
yamacir-kit
merged 10 commits into
master
from
feature/support-latest-autoware-message-type
Feb 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aneId` Signed-off-by: yamacir-kit <[email protected]>
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
This was referenced Jan 28, 2025
NOTE: This PR is waiting for Autoware's release on 0.41.0 |
Signed-off-by: yamacir-kit <[email protected]>
Signed-off-by: yamacir-kit <[email protected]>
Signed-off-by: yamacir-kit <[email protected]>
Signed-off-by: yamacir-kit <[email protected]>
…est-autoware-message-type
Signed-off-by: yamacir-kit <[email protected]>
|
HansRobo
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
feature
New feature or request
wait for regression test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
Support message type
autoware_internal_planning_msgs::msg::PathWithLaneId
.Background
From Pilot.Auto 0.41.0,
autoware_internal_planning_msgs
has been added. Due to the addition of this message type,tier4_planning_msgs::msg::PathWithLaneId
will be replaced byautoware_internal_planning_msgs::msg::PathWithLaneId
from Pilot.Auto 0.41.1 onwards. In other words, Pilot.Auto 0.41.0 is a version to give time for the message type change, and whiletier4_planning_msgs::msg::PathWithLaneId
andautoware_internal_planning_msgs::msg::PathWithLaneId
coexist,tier4_planning_msgs::msg::PathWithLaneId
is the one that is used.To accommodate this change, scenario_simulator_v2 needs to support both message types and be able to switch which one to use. This pull request does this.
Details
The current default
architecture_type
isawf/unvierse/20240605
and this pull request does not change it. (We need to consider how to manage the defaultarchitecture_type
in the future.)architecture_type
isawf/universe/20250130
or later,autoware_internal_planning_msgs::msg::PathWithLaneId
subscribers are instantiated.tier4_planning_msgs::msg::PathWithLaneId
subscribers are instantiated.To achieve the above switch, the class template
Subscriber
has been updated, and some auxiliary class templates have been added for it.References
None.
Destructive Changes
None.
Known Limitations
None.