Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: replace tier4_planning_msgs/PathWithLaneId with autoware_internal_planning_msgs/PathWithLaneId #10023

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat!: replace tier4_planning_msgs/PathWithLaneId with autoware_internal_planning_msgs/PathWithLaneId #10023

wants to merge 5 commits into from
+985 −897

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Jan 27, 2025 •
edited
Loading

Description

This replaces tier4_planning_msgs/PathWithLaneId messages with autoware_internal_planning_msgs/PathWithLaneId to prepare for Autoware Core migration.

Related links

Parent Issue:

This has to be merged with:

This has to be merged before:

How was this PR tested?

The PR was tested on Evaluator:
https://evaluation.ci.tier4.jp/evaluation/reports/094116a4-d603-536a-9385-98b1f6797e62?project_id=prd_jt

Notes for reviewers

None.

Interface changes

Topic changes

Modifications

Version Topic Type Topic Name Message Type
Old Pub/Sub all messages using this type tier4_planning_msgs/PathWithLaneId
New Pub/Sub all messages using this type autoware_internal_planning_msgs/PathWithLaneId

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Jan 27, 2025
@mitsudome-r mitsudome-r marked this pull request as draft January 27, 2025 04:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 27, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 67.74194% with 10 lines in your changes missing coverage. Please review.

Project coverage is 28.37%. Comparing base (b3c69b4) to head (bc26019).

Files with missing lines Patch % Lines
...or_path_planner/src/behavior_path_planner_node.cpp 0.00% 2 Missing ⚠️
...velocity_planner_common/scene_module_interface.hpp 66.66% 2 Missing ⚠️
...e_behavior_velocity_stop_line_module/src/scene.cpp 0.00% 2 Missing ⚠️
common/autoware_trajectory/src/detail/types.cpp 50.00% 1 Missing ⚠️
...ehavior_velocity_blind_spot_module/src/manager.cpp 0.00% 1 Missing ⚠️
...ehavior_velocity_speed_bump_module/src/manager.cpp 0.00% 1 Missing ⚠️
...havior_velocity_traffic_light_module/src/scene.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10023      +/-   ##
==========================================
+ Coverage   28.30%   28.37%   +0.07%     
==========================================
  Files        1484     1485       +1     
  Lines      111090   111094       +4     
  Branches    43151    43152       +1     
==========================================
+ Hits        31441    31521      +80     
+ Misses      76631    76545      -86     
- Partials     3018     3028      +10
Flag Coverage Δ *Carryforward flag
differential 31.33% <67.74%> (?)
total 28.29% <ø> (-0.02%) ⬇️ Carriedforward from 8f0ea32

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r mitsudome-r force-pushed the replace-path-with-lane-id branch from c6f5940 to b494bbb Compare January 27, 2025 14:11
@mitsudome-r mitsudome-r mentioned this pull request Jan 28, 2025
Open
@mitsudome-r mitsudome-r force-pushed the replace-path-with-lane-id branch from b494bbb to 36104f3 Compare January 28, 2025 05:53
@mitsudome-r mitsudome-r marked this pull request as ready for review January 28, 2025 05:53
@mitsudome-r mitsudome-r mentioned this pull request Jan 28, 2025
Open
youtalk
youtalk approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mitsudome-r
Copy link
Member Author

I had a discussion with @yamacir-kit that they would like to wait for a week to merge tier4/scenario_simulator_v2#1518.

@mitsudome-r mitsudome-r force-pushed the replace-path-with-lane-id branch from 36104f3 to 4305379 Compare February 4, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youtalk youtalk youtalk approved these changes

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@danielsanchezaran danielsanchezaran Awaiting requested review from danielsanchezaran danielsanchezaran is a code owner

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@yhisaki yhisaki Awaiting requested review from yhisaki yhisaki is a code owner

@mkuri mkuri Awaiting requested review from mkuri mkuri is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi isamu-takagi is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@maxime-clem maxime-clem Awaiting requested review from maxime-clem maxime-clem is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@yuki-takagi-66 yuki-takagi-66 Awaiting requested review from yuki-takagi-66 yuki-takagi-66 is a code owner

@go-sakayori go-sakayori Awaiting requested review from go-sakayori go-sakayori is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

@mkquda mkquda Awaiting requested review from mkquda mkquda is a code owner

@xtk8532704 xtk8532704 Awaiting requested review from xtk8532704 xtk8532704 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Software Working Group
Status: To Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitsudome-r @youtalk