Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

refactor(experimental): delete Buffer in non-Node tests #1860

Conversation

steveluscher
Copy link
Contributor

Summary

This makes the browser environment closer to an actual browser, because browsers have no access to Buffer.

@steveluscher steveluscher force-pushed the 11-15-refactor_experimental_delete_Buffer_in_non-Node_tests branch from aa45e91 to e3abdd2 Compare November 17, 2023 19:45
Copy link
Contributor

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing some browser tests to fail on the RPC transport package. We should probably update them as part of this PR.

CleanShot 2023-11-18 at 08 30 55@2x

@steveluscher
Copy link
Contributor Author

This is causing some browser tests to fail on the RPC transport package. We should probably update them as part of this PR.

Uggggggggg jest-fetch-mock is pulling in node-fetch whyyyyyy.

@steveluscher
Copy link
Contributor Author

Giving up on this for now. #1867

@lorisleiva lorisleiva deleted the 11-15-refactor_experimental_delete_Buffer_in_non-Node_tests branch November 20, 2023 22:05
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants