This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
[experimental] Eliminate jest-fetch-mock
#1867
Labels
Comments
steveluscher
added a commit
that referenced
this issue
Feb 24, 2024
# Summary In this massive PR we eliminate the `fetch` mocking framework. The _only_ module that should be mocking all the way down to `fetch` is the module that depends directly on `fetch` – `@solana/rpc-transport-http`. Everything else should be able to mock one or several layers higher. Closes #1867.
|
🎉 This issue has been resolved in version 1.90.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this issue for 7 days since it was closed, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We use
fetchat the heart of the http transports now, for both Node and the browser.The fact that
jest-fetch-mockdepends onnode-fetch(throughcross-fetch) is now problematic.In particular, it prevented us from landing #1860.
node-fetchdepends onBufferso we couldn't null outBufferfor browser tests.The task here is to create a
fetchmock for tests from scratch, withoutjest-fetch-mock, or to find one that does not rely onnode-fetch.The text was updated successfully, but these errors were encountered: