Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

refactor(experimental): add constants to web3.js sham #1862

Merged
merged 2 commits into from
Nov 20, 2023
Merged

refactor(experimental): add constants to web3.js sham #1862

merged 2 commits into from
Nov 20, 2023

Conversation

steveluscher
Copy link
Contributor

@steveluscher steveluscher commented Nov 17, 2023 •
edited
Loading

Addresses #1825.

This was referenced Nov 17, 2023
Closed
Merged
@steveluscher
Copy link
Contributor Author

steveluscher commented Nov 17, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Nov 17, 2023
Merged
Merged
@steveluscher steveluscher force-pushed the 11-15-refactor_experimental_create_a_sham_for_PublicKey_ branch from 8036a03 to f9982dd Compare November 17, 2023 19:45
@steveluscher steveluscher force-pushed the 11-15-refactor_experimental_add_constants_to_web3.js_sham branch from d3dafa5 to 2ffd298 Compare November 17, 2023 19:45
buffalojoec
buffalojoec approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but I think I'm going to take this opportunity to cast my vote for adding LAMPORTS_PER_SOL to the new library.

People are going to be quite irked if that's gone.

@steveluscher
Copy link
Contributor Author

It's not going to be that useful. The second that someone tries to do division they'll discover that you can't do division with bigint.

It might be more useful to create a bunch of math helpers (also OMG I'd rather leave that up to others so that they carefully think about how and when they round).

@steveluscher steveluscher force-pushed the 11-15-refactor_experimental_create_a_sham_for_PublicKey_ branch from f9982dd to 516772f Compare November 20, 2023 21:46
@steveluscher steveluscher force-pushed the 11-15-refactor_experimental_add_constants_to_web3.js_sham branch from 2ffd298 to 72b32f2 Compare November 20, 2023 21:46
@steveluscher
Copy link
Contributor Author

steveluscher commented Nov 20, 2023 •
edited
Loading

Merge activity

Base automatically changed from 11-15-refactor_experimental_create_a_sham_for_PublicKey_ to master November 20, 2023 21:52
@steveluscher steveluscher force-pushed the 11-15-refactor_experimental_add_constants_to_web3.js_sham branch from 72b32f2 to c2f6390 Compare November 20, 2023 21:53
@steveluscher steveluscher merged commit 735654a into master Nov 20, 2023
5 of 6 checks passed
@steveluscher steveluscher deleted the 11-15-refactor_experimental_add_constants_to_web3.js_sham branch November 20, 2023 21:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@buffalojoec buffalojoec buffalojoec approved these changes

@lorisleiva lorisleiva lorisleiva approved these changes

@mcintyre94 mcintyre94 mcintyre94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steveluscher @mcintyre94 @lorisleiva @buffalojoec