Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not handle new global-level workflow dependencies #209

Open
jbloom opened this issue Dec 26, 2023 · 1 comment
Open

does not handle new global-level workflow dependencies #209

jbloom opened this issue Dec 26, 2023 · 1 comment

Comments

@jbloom
Copy link

jbloom commented Dec 26, 2023

Starting in snakemake version 8, global workflow dependencies are allowed as here. This code looks like this in the top-level Snakefile:

conda:
    "envs/global.yaml"

However, this raises an error in snakefmt.

@mbhall88
Copy link
Member

mbhall88 commented Jan 2, 2024

Hi @jbloom thanks for reporting this.

The new version of snakemake requires python>=3.11, which presents some issues for us as we rely on snakemake for testing. Long story short we would either need to increase the python min. version for snakefmt to match snakemake (which I am a little hesistant to do), or remove snakemake from our dev dependencies.

I would prefer the second option, but this will take time. The reason for this is we are in discussions about creating a concrete grammar and parser for snakemake files, which would mean we would only need to rely on the grammar/parser and not the whole snakemake package itself. This will also significantly improve our ability to fix bugs, which have been extremely difficult without a snakemake parser.

Thank you for your patience while we try and sort this all out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants