Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GitHub Release Script #674

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Refactor GitHub Release Script #674

merged 3 commits into from
Jul 3, 2024

Conversation

nlordell
Copy link
Collaborator

@nlordell nlordell commented Jul 1, 2024

This PR completely refactors the release script 🙈.

The previous script was built on the assumption that GitHub actions could push to protected branches, but it turns out that this is kind of complicated to setup without sacrificing some branch protections that we apply to main and I don't want to touch.

Instead, we change the release flow to:

  1. Automatically create a PR to GitHub to bump the version
  2. Create a draft release
  3. Publish the draft release once it shows up on NPM.

Test Plan

This script should do all that now, and once this merges, we should be able to test the flow by:

  1. Triggering the flow to create the version bump PR
  2. Merge the version bump PR
  3. Triggering the flow to create a draft release
  4. NPM publish the tarball attached to the release
  5. Triggering the flow to publish the draft release

Tested on my local fork and was able to automatically create releases.

Screenshots

image

image

image

Future Work

Once the private runner that publishes to NPM is setup, we can run the action hourly.

@nlordell nlordell requested review from gjeanmart and a team as code owners July 1, 2024 11:44
@nlordell nlordell requested review from akshay-ap, mmv08 and remedcu July 1, 2024 11:44
@nlordell nlordell merged commit 76883ad into main Jul 3, 2024
1 check passed
@nlordell nlordell deleted the 660/multi-release-action branch July 3, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants