-
Notifications
You must be signed in to change notification settings - Fork 301
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor GitHub Release Script (#674)
This PR completely refactors the release script 🙈. The previous script was built on the assumption that GitHub actions could push to protected branches, but it turns out that this is kind of complicated to setup without sacrificing some branch protections that we apply to `main` and I don't want to touch. Instead, we change the release flow to: 1. Automatically create a PR to GitHub to bump the version 2. Create a draft release 3. Publish the draft release once it shows up on NPM. ### Test Plan This script should do all that now, and once this merges, we should be able to test the flow by: 1. Triggering the flow to create the version bump PR 2. Merge the version bump PR 3. Triggering the flow to create a draft release 4. NPM publish the tarball attached to the release 5. Triggering the flow to publish the draft release Tested on my local fork and was able to automatically create releases. <details><summary>Screenshots</summary> ![image](https://github.com/safe-global/safe-deployments/assets/4210206/747fcf6f-4e9a-4c5a-8f8d-bc6955c345a7) ![image](https://github.com/safe-global/safe-deployments/assets/4210206/52e5e6c6-a428-4bd6-9d30-4264c29ce6d3) ![image](https://github.com/safe-global/safe-deployments/assets/4210206/bda8cd1c-74a2-43ae-bf22-5e0069d06d5d) </details> ### Future Work Once the private runner that publishes to NPM is setup, we can run the action hourly.
- Loading branch information
Showing
2 changed files
with
89 additions
and
37 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ on: | |
|
||
permissions: | ||
contents: write | ||
pull-requests: write | ||
|
||
jobs: | ||
release: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters