Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Automated Draft Releases #682

Closed
nlordell opened this issue Jul 4, 2024 · 1 comment
Closed

Publish Automated Draft Releases #682

nlordell opened this issue Jul 4, 2024 · 1 comment
Assignees

Comments

@nlordell
Copy link
Collaborator

nlordell commented Jul 4, 2024

While https://github.com/safe-global/safe-deployments/issue/660 and #674 added support for bumping versions and drafting GitHub releases automatically, the publishing feature of the script was not working as intended and causing validation errors:

current: v1.37.1
latest:  v1.37.1
commit:  542b2efceb60f8937467bee58bab580959a50a39
draft:   542b2efceb60f8937467bee58bab580959a50a39
==> Publishing Release
publishing draft release
HTTP 422: Validation Failed (https://api.github.com/repos/safe-global/safe-deployments/releases/163975682)
pre_receive Repository rule violations found
Cannot create ref due to create name restrictions.
Published releases must have a valid tag

However, the command runs locally 🤷.

Since only the pre-release feature was covered by #660, I created a new issue to address the required fix for publishing draft releases.

Expected Outcome

One of:

  • Find the magic incantation to make release publishing work in CI
  • Document required changes to our release flow to make it work
@nlordell nlordell self-assigned this Jul 5, 2024
@nlordell
Copy link
Collaborator Author

This was fixed by a GitHub permission setting to allow creation of tags by CI.

https://github.com/safe-global/safe-deployments/actions/runs/9975305349/job/27564711644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant