-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create footprint_collision_checker.py #4899
Conversation
Backport of footprint_collision_checker to Nav2 Humble Signed-off-by: ThomasHaley-neya <[email protected]>
@ThomasHaley-neya, all pull requests must be targeted towards the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThomasHaley-neya just sanity check me that you've tested this generally speaking and it works / doesn't crash from incorrect members.
Yep, just went back and tested all member functions and everything seems kosher. A crash can happen if the user calls setCostmap() and passes something other than an occupancy grid, but that is the same behavior that occurs on main. Maybe another ticket should be opened to add a check there? |
If the wrong thing is passed in, then I suppose that should be expected in Python without type checking |
Backport of footprint_collision_checker to Nav2 Humble Signed-off-by: ThomasHaley-neya <[email protected]>
* Update Smac Planner for rounding to closest bin rather than flooring (ros-navigation#4636) (ros-navigation#4760) Co-authored-by: Steve Macenski <[email protected]> * fixing path longer on approach (ros-navigation#4622) (ros-navigation#4766) * fixing path longer on approach * removing the short circuit * adding additional layer of check --------- Signed-off-by: Pradheep <[email protected]> * Add acceleration limits to DriveOnHeading and BackUp behaviors (backport ros-navigation#4810) (ros-navigation#4877) * Add acceleration limits to DriveOnHeading and BackUp behaviors (ros-navigation#4810) * Add acceleration constraints Signed-off-by: RBT22 <[email protected]> * Cleanup code Signed-off-by: RBT22 <[email protected]> * Format code Signed-off-by: RBT22 <[email protected]> * Add <limits> header to drive_on_heading.hpp Signed-off-by: RBT22 <[email protected]> * Remove vel pointer Signed-off-by: RBT22 <[email protected]> * Use the limits only if both of them is set Signed-off-by: RBT22 <[email protected]> * Fix onActionCompletion params Signed-off-by: RBT22 <[email protected]> * Add default acc params and change decel sign Signed-off-by: RBT22 <[email protected]> * Add minimum speed parameter Signed-off-by: RBT22 <[email protected]> * Update minimum speed parameter to 0.10 Signed-off-by: RBT22 <[email protected]> * Log warning when acceleration or deceleration limits are not set Signed-off-by: RBT22 <[email protected]> * Add param sign assert Signed-off-by: RBT22 <[email protected]> * Remove unnecessary param checking Signed-off-by: RBT22 <[email protected]> * Refactor acceleration limits to handle forward and backward movement separately Signed-off-by: RBT22 <[email protected]> * Fix sign checking condition Signed-off-by: RBT22 <[email protected]> * Replace throwing with silent sign correction Signed-off-by: RBT22 <[email protected]> --------- Signed-off-by: RBT22 <[email protected]> * Update parameter defaults to zero Signed-off-by: RBT22 <[email protected]> * Add off condition Signed-off-by: RBT22 <[email protected]> * Move forward outside Signed-off-by: RBT22 <[email protected]> --------- Signed-off-by: RBT22 <[email protected]> * Add option to use open-loop control with Rotation Shim (backport ros-navigation#4880) (ros-navigation#4896) * Add option to use open-loop control with Rotation Shim (ros-navigation#4880) * Initial implementation Signed-off-by: RBT22 <[email protected]> * replace feedback param with closed_loop Signed-off-by: RBT22 <[email protected]> * Reset last_angular_vel_ in activate method Signed-off-by: RBT22 <[email protected]> * Add closed_loop parameter to dynamicParametersCallback Signed-off-by: RBT22 <[email protected]> * Add tests Signed-off-by: RBT22 <[email protected]> * Override reset function Signed-off-by: RBT22 <[email protected]> --------- Signed-off-by: RBT22 <[email protected]> * Remove reset Signed-off-by: RBT22 <[email protected]> --------- Signed-off-by: RBT22 <[email protected]> * Create footprint_collision_checker.py (ros-navigation#4899) Backport of footprint_collision_checker to Nav2 Humble Signed-off-by: ThomasHaley-neya <[email protected]> --------- Signed-off-by: Pradheep <[email protected]> Signed-off-by: RBT22 <[email protected]> Signed-off-by: ThomasHaley-neya <[email protected]> Co-authored-by: LinusTxtonomy <[email protected]> Co-authored-by: Steve Macenski <[email protected]> Co-authored-by: Pradheep Krishna <[email protected]> Co-authored-by: ThomasHaley-neya <[email protected]>
Backport of footprint_collision_checker to Nav2 Humble
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
For Maintainers: