Fix C++ linking error on macOS / Windows due to missing libraries #8991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rerun-bot full-check |
grtlr
added
the
exclude from changelog
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/13261539480 |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/13261569569 |
grtlr
force-pushed
the
grtlr/fix-cpp-certificate-apple
branch
from
8388748 to
ee9d6b4
Compare
grtlr
force-pushed
the
grtlr/fix-cpp-certificate-apple
branch
from
ee9d6b4 to
5181d4d
Compare
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/13262277136 |
Wumpf
reviewed
Feb 11, 2025
rerun_cpp/CMakeLists.txt
Outdated
| elseif(UNIX) # if(LINUX) # CMake 3.25 | ||
| target_link_libraries(rerun_c INTERFACE "-lm -ldl -pthread") | ||
| elseif(WIN32) | ||
| target_link_libraries(rerun_c INTERFACE ws2_32.dll Bcrypt.dll Userenv.dll ntdll.dll) | ||
| target_link_options(rerun_c INTERFACE "/NODEFAULTLIB:MSVCRT") |
There was a problem hiding this comment.
why is this needed, seems very fishy
grtlr
changed the title
cpp linking error on macOS due to missing frameworks
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/13264430271 |
Wumpf
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
It looks like we were missing some macOS
frameworks that are required for linkingtonicwhen using native certificates.