Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C++ linking error on macOS / Windows due to missing libraries #8991

Merged
merged 7 commits into from
Feb 11, 2025
+2 −2
Merged

Fix C++ linking error on macOS / Windows due to missing libraries #8991

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d605bd0
Fix `cpp` linking error on `macOS` due to missing `framework`s
grtlr Feb 11, 2025
339f7b8
remove duplicate
grtlr Feb 11, 2025
5181d4d
plz work :crying_cat_face:
grtlr Feb 11, 2025
24bcbb3
now maybe?
grtlr Feb 11, 2025
eb2e434
try again
grtlr Feb 11, 2025
3813b31
add `Secur32`
grtlr Feb 11, 2025
6005b8a
Add `Ncrypt` too
grtlr Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rerun_cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,11 @@ if(NOT TARGET rerun_c)
endif()

if(APPLE)
target_link_libraries(rerun_c INTERFACE "-framework CoreFoundation" "-framework IOKit")
target_link_libraries(rerun_c INTERFACE "-framework CoreFoundation" "-framework IOKit" "-framework Security")
elseif(UNIX) # if(LINUX) # CMake 3.25
target_link_libraries(rerun_c INTERFACE "-lm -ldl -pthread")
elseif(WIN32)
target_link_libraries(rerun_c INTERFACE ws2_32.dll Bcrypt.dll Userenv.dll ntdll.dll)
target_link_libraries(rerun_c INTERFACE ws2_32 Bcrypt Userenv ntdll Crypt32 Secur32 Ncrypt)
endif()

target_link_libraries(rerun_sdk PRIVATE rerun_c)
Expand Down
Loading