Skip to content

Commit

Permalink
Fix C++ linking error on macOS / Windows due to missing libraries (#8991
Browse files Browse the repository at this point in the history
)

### Related

* https://github.com/rerun-io/rerun/actions/runs/13260534162

### What

It looks like we were missing some macOS `framework`s that are required
for linking `tonic` when using native certificates.
  • Loading branch information
grtlr authored Feb 11, 2025
1 parent d39fcfe commit d81064c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions rerun_cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,11 @@ if(NOT TARGET rerun_c)
endif()

if(APPLE)
target_link_libraries(rerun_c INTERFACE "-framework CoreFoundation" "-framework IOKit")
target_link_libraries(rerun_c INTERFACE "-framework CoreFoundation" "-framework IOKit" "-framework Security")
elseif(UNIX) # if(LINUX) # CMake 3.25
target_link_libraries(rerun_c INTERFACE "-lm -ldl -pthread")
elseif(WIN32)
target_link_libraries(rerun_c INTERFACE ws2_32.dll Bcrypt.dll Userenv.dll ntdll.dll)
target_link_libraries(rerun_c INTERFACE ws2_32 Bcrypt Userenv ntdll Crypt32 Secur32 Ncrypt)
endif()

target_link_libraries(rerun_sdk PRIVATE rerun_c)
Expand Down

0 comments on commit d81064c

Please sign in to comment.