Move tests/assets/video over to git-lfs
#8936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🔨 testing
Wumpf
requested changes
Feb 5, 2025
|
there's more! rust_checks.py for instance and some ymls |
|
for the yml you need to make sure that those jobs pull lfs now |
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/13161672076 |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/13161954049 |
|
(still one last thing to fix but im on another fire right now) |
Wumpf
approved these changes
Feb 5, 2025
teh-cmc
force-pushed
the
cmc/lfs_assets
branch
from
458e41f to
07b7ed2
Compare
|
Passed ✨ |
emilk
pushed a commit
that referenced
this pull request
Feb 6, 2025
teh-cmc
added a commit
that referenced
this pull request
Feb 10, 2025
It's a bit of an odd one because of the way the dataloader works, but I would still feel much better with an odd test than no tests at all. I've uploaded a heavily sampled down `apple_storage` dataset to LFS in order to make this work. * DNM: requires #8936
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title.
git-lfsto our CI container #8946