Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist for LeRobot dataloader #8949

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Checklist for LeRobot dataloader #8949

merged 4 commits into from
Feb 10, 2025

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Feb 6, 2025

It's a bit of an odd one because of the way the dataloader works, but I would still feel much better with an odd test than no tests at all.

I've uploaded a heavily sampled down apple_storage dataset to LFS in order to make this work.

Copy link

github-actions bot commented Feb 6, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
dcbf2df https://rerun.io/viewer/pr/8949 +nightly +main

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc force-pushed the cmc/lerobot_checklist branch 2 times, most recently from 5e9b389 to 5639d32 Compare February 6, 2025 11:19
@teh-cmc teh-cmc added 🔨 testing testing and benchmarks exclude from changelog PRs with this won't show up in CHANGELOG.md labels Feb 6, 2025
@teh-cmc teh-cmc force-pushed the cmc/lerobot_checklist branch from 5639d32 to 840031a Compare February 6, 2025 11:20
@teh-cmc teh-cmc added do-not-merge Do not merge this PR and removed do-not-merge Do not merge this PR labels Feb 6, 2025
@teh-cmc teh-cmc marked this pull request as ready for review February 6, 2025 11:27
Base automatically changed from cmc/lfs_assets to main February 7, 2025 08:42
@teh-cmc teh-cmc force-pushed the cmc/lerobot_checklist branch from 840031a to 0e97711 Compare February 7, 2025 08:43
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Feb 7, 2025
@teh-cmc
Copy link
Member Author

teh-cmc commented Feb 10, 2025

I'll sample even more aggressively (not sure why I kept 10 rather than.. I dunno, 3 maybe?) then merge this.

@teh-cmc teh-cmc force-pushed the cmc/lerobot_checklist branch from 0e97711 to 1817306 Compare February 10, 2025 09:32
@teh-cmc teh-cmc merged commit 87564f7 into main Feb 10, 2025
34 of 35 checks passed
@teh-cmc teh-cmc deleted the cmc/lerobot_checklist branch February 10, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🔨 testing testing and benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant