Move tests/assets/video over to git-lfs

.gitattributes

@@ -5,3 +5,4 @@ pixi.lock linguist-generated=true
 
 # git-lfs stuff
 **/snapshots/**/*.png filter=lfs diff=lfs merge=lfs -text
+tests/assets/video/*.mp4 filter=lfs diff=lfs merge=lfs -text

.github/workflows/contrib_rerun_py.yml

@@ -47,7 +47,7 @@ jobs:
     name: Build Wheels
     runs-on: ubuntu-latest-16-cores
     container:
-      image: rerunio/ci_docker:0.14.0
+      image: rerunio/ci_docker:0.15.0
     steps:
       - uses: actions/checkout@v4
 

.github/workflows/reusable_bench.yml

@@ -84,9 +84,6 @@ jobs:
             default
             wheel-test-min
 
-      - name: Download test assets
-        run: pixi run -e wheel-test-min python ./tests/assets/download_test_assets.py
-
       - name: Add SHORT_SHA env property with commit short sha
         run: echo "SHORT_SHA=`echo ${{github.sha}} | cut -c1-7`" >> $GITHUB_ENV
 

.github/workflows/reusable_build_and_upload_rerun_c.yml

@@ -89,13 +89,13 @@ jobs:
             linux-arm64)
               runner="buildjet-8vcpu-ubuntu-2204-arm"
               target="aarch64-unknown-linux-gnu"
-              container="'rerunio/ci_docker:0.14.0'"
+              container="'rerunio/ci_docker:0.15.0'"
               lib_name="librerun_c.a"
               ;;
             linux-x64)
               runner="ubuntu-latest-16-cores"
               target="x86_64-unknown-linux-gnu"
-              container="'rerunio/ci_docker:0.14.0'"
+              container="'rerunio/ci_docker:0.15.0'"
               lib_name="librerun_c.a"
               ;;
             windows-x64)

.github/workflows/reusable_build_and_upload_rerun_cli.yml

@@ -90,13 +90,13 @@ jobs:
             linux-arm64)
               runner="buildjet-8vcpu-ubuntu-2204-arm"
               target="aarch64-unknown-linux-gnu"
-              container="'rerunio/ci_docker:0.14.0'"
+              container="'rerunio/ci_docker:0.15.0'"
               bin_name="rerun"
               ;;
             linux-x64)
               runner="ubuntu-latest-16-cores"
               target="x86_64-unknown-linux-gnu"
-              container="'rerunio/ci_docker:0.14.0'"
+              container="'rerunio/ci_docker:0.15.0'"
               bin_name="rerun"
               ;;
             windows-x64)

.github/workflows/reusable_build_and_upload_wheels.yml

@@ -113,14 +113,14 @@ jobs:
             linux-arm64)
                 runner="buildjet-8vcpu-ubuntu-2204-arm"
                 target="aarch64-unknown-linux-gnu"
-                container="'rerunio/ci_docker:0.14.0'" # Required to be manylinux compatible
+                container="'rerunio/ci_docker:0.15.0'" # Required to be manylinux compatible
                 compat="manylinux_2_31"
                 ;;
             linux-x64)
               runner="ubuntu-latest-16-cores"
               target="x86_64-unknown-linux-gnu"
               compat="manylinux_2_31"
-              container="'rerunio/ci_docker:0.14.0'" # Required to be manylinux compatible
+              container="'rerunio/ci_docker:0.15.0'" # Required to be manylinux compatible
               ;;
             windows-x64)
               runner="windows-latest-8-cores"

.github/workflows/reusable_bundle_and_upload_rerun_cpp.yml

@@ -31,7 +31,7 @@ jobs:
     name: Bundle and upload rerun_cpp_sdk.zip
     runs-on: ubuntu-latest
     container:
-      image: rerunio/ci_docker:0.14.0 # Need container for arrow dependency.
+      image: rerunio/ci_docker:0.15.0 # Need container for arrow dependency.
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4

.github/workflows/reusable_checks_rust.yml

@@ -89,9 +89,6 @@ jobs:
         if: ${{ inputs.CHANNEL == 'pr' }}
         run: pixi run rs-check --only base_checks sdk_variations cargo_deny wasm docs
 
-      - name: Download test assets
-        run: pixi run python ./tests/assets/download_test_assets.py
-
       - name: Run tests (`cargo test --all-targets --all-features`)
         if: ${{ inputs.CHANNEL == 'pr' }}
         # Need to use pixi due to NASM dependency.
@@ -151,9 +148,6 @@ jobs:
       - name: Setup software rasterizer
         run: pixi run python ./scripts/ci/setup_software_rasterizer.py
 
-      - name: Download test assets
-        run: pixi run python ./tests/assets/download_test_assets.py
-
       - name: Run tests (`cargo test --all-targets --all-features`)
         if: ${{ inputs.CHANNEL == 'main' }}
         # Need to use pixi due to NASM dependency.

.github/workflows/reusable_run_notebook.yml

@@ -28,7 +28,7 @@ jobs:
     name: Run notebook
     runs-on: ubuntu-latest-16-cores # Note that as of writing we need the additional storage page (14 gb of the ubunut-latest runner is not enough).
     container:
-      image: rerunio/ci_docker:0.14.0 # Required to run the wheel or we get "No matching distribution found for attrs>=23.1.0" during `pip install rerun-sdk`
+      image: rerunio/ci_docker:0.15.0 # Required to run the wheel or we get "No matching distribution found for attrs>=23.1.0" during `pip install rerun-sdk`
     steps:
       - uses: actions/checkout@v4
         with:

.github/workflows/reusable_test_wheels.yml

@@ -79,12 +79,12 @@ jobs:
             linux-arm64)
               runner="buildjet-8vcpu-ubuntu-2204-arm"
               target="aarch64-unknown-linux-gnu"
-              container="'rerunio/ci_docker:0.14.0'"
+              container="'rerunio/ci_docker:0.15.0'"
               ;;
             linux-x64)
               runner="ubuntu-latest-16-cores"
               target="x86_64-unknown-linux-gnu"
-              container="'rerunio/ci_docker:0.14.0'"
+              container="'rerunio/ci_docker:0.15.0'"
               ;;
             windows-x64)
               runner="windows-latest-8-cores"
@@ -137,6 +137,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           ref: ${{ inputs.RELEASE_COMMIT || ((github.event_name == 'pull_request' && github.event.pull_request.head.ref) || '') }}
+          lfs: true
 
       - name: Set up Rust
         uses: ./.github/actions/setup-rust
@@ -214,12 +215,6 @@ jobs:
         # This used to cause issues on Windows during the setup of the pixi environment when running from inside `compare_snippet_output.py`.
         run: pixi run -e wheel-test-min cpp-build-snippets
 
-      - name: Download test assets
-        if: ${{ !inputs.FAST }}
-        # Separated out of compare_snippet_output.py run so we control the pixi environment.
-        # This used to cause issues on Windows during the setup of the pixi environment when running from inside `compare_snippet_output.py`.
-        run: pixi run -e wheel-test-min python ./tests/assets/download_test_assets.py
-
       - name: Run docs/snippets/compare_snippet_output.py
         if: ${{ !inputs.FAST }}
         # explicit target because otherwise cargo loses the target cache… even though this is the target anyhow…

ci_docker/Dockerfile

@@ -2,7 +2,7 @@ FROM ubuntu:20.04
 LABEL maintainer="[email protected]"
 # Remember to update the version in publish.sh
 # TODO(jleibs) use this version in the publish.sh script and below in the CACHE_KEY
-LABEL version="0.14.0"
+LABEL version="0.15.0"
 LABEL description="Docker image used for the CI of https://github.com/rerun-io/rerun"
 
 # Install the ubuntu package dependencies
@@ -21,6 +21,7 @@ RUN set -eux; \
     cmake \
     curl \
     git \
+    git-lfs \
     libatk-bridge2.0 \
     libfontconfig1-dev \
     libfreetype6-dev \
@@ -45,7 +46,7 @@ ENV RUSTUP_HOME=/usr/local/rustup \
 RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
 
 # Increment this to invalidate cache
-ENV CACHE_KEY=rerun_docker_v0.14.0
+ENV CACHE_KEY=rerun_docker_v0.15.0
 
 # See: https://github.com/actions/runner-images/issues/6775#issuecomment-1410270956
 RUN git config --system --add safe.directory '*'

ci_docker/README.md

@@ -0,0 +1,7 @@
+If you see this error while trying to publish:
+> ERROR: failed to solve: failed to compute cache key: failed to rename: rename /var/lib/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/new-3352706846 /var/lib/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/33: file exists: unknown
+
+It means your docker cache is corrupt. Fix it by pruning the cache:
+```sh
+docker system prune -af
+```

ci_docker/publish.sh

@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 set -eux
 
-VERSION=0.14.0 # Bump on each new version. Remember to update the version in the Dockerfile too.
+VERSION=0.15.0 # Bump on each new version. Remember to update the version in the Dockerfile too.
 
 # The build needs to run from top of repo to access the requirements.txt
 cd `git rev-parse --show-toplevel`

crates/build/re_dev_tools/src/build_examples/snippets.rs

@@ -36,9 +36,7 @@ impl Snippets {
         let snippet_root = snippets_dir.join("all");
         let snippets = collect_snippets_recursively(&snippet_root, &config, &snippet_root)?;
 
-        println!("Download test assets…");
         let progress = MultiProgress::new();
-        download_test_assets(&progress)?;
 
         println!("Running {} snippets…", snippets.len());
         let results: Vec<anyhow::Result<PathBuf>> = snippets
@@ -193,12 +191,3 @@ struct OptOut {
     /// example name -> languages
     run: HashMap<String, Vec<String>>,
 }
-
-fn download_test_assets(progress: &MultiProgress) -> anyhow::Result<()> {
-    let download_script = re_build_tools::cargo_metadata()?
-        .workspace_root
-        .join("tests/assets/download_test_assets.py");
-    let mut cmd = Command::new("python3");
-    cmd.arg(download_script.as_str());
-    wait_for_output(cmd, "download test assets", progress)
-}

docs/snippets/compare_snippet_output.py

@@ -71,7 +71,6 @@ def main() -> None:
     parser = argparse.ArgumentParser(description="Run end-to-end cross-language roundtrip tests for all API examples")
     parser.add_argument("--no-py", action="store_true", help="Skip Python tests")
     parser.add_argument("--no-cpp", action="store_true", help="Skip C++ tests")
-    parser.add_argument("--no-asset-download", action="store_true", help="Skip downloading test assets")
     # We don't allow skipping Rust - it is what we compate to at the moment
     parser.add_argument("--no-py-build", action="store_true", help="Skip building rerun-sdk for Python")
     parser.add_argument(
@@ -138,13 +137,6 @@ def main() -> None:
 
     print("----------------------------------------------------------")
 
-    if not args.no_asset_download:
-        print("Downloading test assets…")
-        run(["pixi", "run", "python3", "./tests/assets/download_test_assets.py"])
-        print("")
-
-        print("----------------------------------------------------------")
-
     active_languages = ["rust"]
     if not args.no_cpp:
         active_languages.append("cpp")

docs/snippets/snippets.toml

@@ -290,7 +290,6 @@ quick_start = [ # These examples don't have exactly the same implementation.
 ]
 
 # `$config_dir` will be replaced with the absolute path of `docs/snippets`.
-# Note that the snippet comparison tool will automatically run `/tests/assets/download_test_assets.py` before running the snippets.
 [extra_args]
 "archetypes/asset3d_simple" = ["$config_dir/../../tests/assets/cube.glb"]
 "archetypes/asset3d_out_of_tree" = ["$config_dir/../../tests/assets/cube.glb"]

scripts/ci/rust_checks.py

@@ -254,10 +254,6 @@ def docs_slow(results: list[Result]) -> None:
 def tests(results: list[Result]) -> None:
     # We first use `--no-run` to measure the time of compiling vs actually running
 
-    # Make sure we have the test assets first.
-    print("Downloading test assets…")
-    subprocess.run([sys.executable, "tests/assets/download_test_assets.py"])
-
     # Just a normal `cargo test` should always work:
     results.append(run_cargo("test", "--all-targets --no-run"))
     results.append(run_cargo("test", "--all-targets"))

tests/python/release_checklist/main.py

@@ -4,10 +4,7 @@
 import argparse
 import glob
 import importlib
-import subprocess
-import sys
 from os.path import basename, dirname, isfile, join
-from pathlib import Path
 
 import rerun as rr
 
@@ -31,12 +28,6 @@ def main() -> None:
     rr.script_add_args(parser)
     args = parser.parse_args()
 
-    # Download test assets:
-    download_test_assets_path = (
-        Path(__file__).parent.parent.parent.joinpath("assets/download_test_assets.py").absolute()
-    )
-    subprocess.run([sys.executable, download_test_assets_path])
-
     log_checks(args)
 
     # Log instructions last so that's what people see first.