Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI command for non-local API configuration #2233

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 21, 2025

What does this implement/fix?

In the corner-case of a user explicitly having configured Pi-hole to NOT listen on lo (because there may be another webserver, etc.), the pihole CLI command may be unable to communicate with the API due to the hard-coded path "localhost". Change this to use the special "pi.hole" host name where interface-dependent replying is already implemented


Related issue or feature (if applicable): Fixes #2192

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER added the Bugfix label Feb 21, 2025
@DL6ER DL6ER changed the title Fix CLI command for non-local API configuration Feb 21, 2025
…NOT listen on lo (because there may be another webserver, etc.), the pihole CLI command may be unable to communicate with the API due to the hard-coded path "localhost". Change this to use the special "pi.hole" host name where interface-dependent replying is already implemented

Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER force-pushed the fix/local_api_no_lo branch from 35cce99 to 47688b9 Compare February 21, 2025 09:22
@yubiuser yubiuser linked an issue Feb 21, 2025 that may be closed by this pull request
@DL6ER DL6ER merged commit c4cb552 into development Feb 22, 2025
19 checks passed
@DL6ER DL6ER deleted the fix/local_api_no_lo branch February 22, 2025 08:00
This was referenced Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_api_string local not using configured ip adresses
2 participants