Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pi-hole FTL v6.0.3 #2296

Open
wants to merge 70 commits into
base: master
Choose a base branch
from
Open

Pi-hole FTL v6.0.3 #2296

wants to merge 70 commits into from
+541 −235

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 26, 2025 •
edited
Loading

What does this implement/fix?

It's time for another release, we have accumulated quite a few fixes and improvements:

Ready for review + merge but could also wait:

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

rrobgill and others added 30 commits February 20, 2025 13:45
@rrobgill
Fix typo in dns.showDNSSEC text description
ecec0c7 
Signed-off-by: Rob Gill <[email protected]>
@DL6ER
In the corner-case of a user explicitly having configured Pi-hole to …
47688b9 
…NOT listen on lo (because there may be another webserver, etc.), the pihole CLI command may be unable to communicate with the API due to the hard-coded path "localhost". Change this to use the special "pi.hole" host name where interface-dependent replying is already implemented

Signed-off-by: DL6ER <[email protected]>
@DL6ER
Clarify the role of dns.domain outside of the DHCP context
0c1eced 
Signed-off-by: DL6ER <[email protected]>
@DL6ER
Return early if no setupVars.conf is found
8857659 
Signed-off-by: DL6ER <[email protected]>
@PromoFaux
Merge pull request #2243 from pi-hole/master
ce95de1 
Sync master back into development
@bennettmsherman
Reduce log level for web requests
7262590 
Signed-off-by: Ben Sherman <[email protected]>
@DL6ER
Merge pull request #2238 from pi-hole/tweak/skip_no_setupVars
4554134 
Do not try to migrate setupVars.conf if it does not exist.
@DL6ER
Merge pull request #2233 from pi-hole/fix/local_api_no_lo
c4cb552 
Fix CLI command for non-local API configuration
@DL6ER
Fix typo
f8c27c2 
Signed-off-by: DL6ER <[email protected]>
@DL6ER
Print human-readable explanation when getting secure randomness fails…
8a2225f 
… to ease debugging

Signed-off-by: DL6ER <[email protected]>
@DL6ER
Create a new randomess generating function that retries on interrupti…
633c205 
…on by external signals, etc.

Signed-off-by: DL6ER <[email protected]>
@DL6ER
Merge pull request #2239 from pi-hole/fix/dns_domain_docs
619d837 
Clarify the role of dns.domain outside of the DHCP context
@DL6ER
Merge pull request #2244 from bennettmsherman/patch-1
8082208 
Reduce log level for web requests
@yubiuser
Merge pull request #2240 from pi-hole/tweak/explain_random_errs
23fd011 
Improve secure randomness generation
@DL6ER
Make additional_headers propery of the embedded webserver CivetWeb ed…
f2ce4bc 
…itable by users via the new config option webserver.headers

Signed-off-by: DL6ER <[email protected]>
@DL6ER
Allowed properties cannot be NULL for some config item types. Add a c…
10cfd31 
…heck for this during config parsing.

Signed-off-by: DL6ER <[email protected]>
@DL6ER
Merge branch 'development' of github.com:rrobgill/FTL into rrobgill-d…
0934da5 
…evelopment
@DL6ER
Add the necessary changes in pihole.toml
4558911 
Signed-off-by: DL6ER <[email protected]>
@DL6ER
Add allowed values to test/pihole.toml
bc6104e 
Signed-off-by: DL6ER <[email protected]>
@DL6ER
Merge pull request #2246 from pi-hole/rrobgill-development
0f2bcf3 
Fix typo in dns.showDNSSEC text description
@DL6ER
\t is a valid separator for dns.hosts entries, too
04253ed 
Signed-off-by: DL6ER <[email protected]>
@DL6ER
Add parsing support for trailing #-comments in the dns.hosts entries
2f1ad68 
Signed-off-by: DL6ER <[email protected]>
@DL6ER
Merge pull request #2247 from pi-hole/tweak_dns_hosts_tabs
41ae9d4 
Allow tabs in dns.hosts
@DL6ER
Also make <domain> optional in the setupVars.conf migration process
5bcd1a0 
Signed-off-by: DL6ER <[email protected]>
@DL6ER
Merge pull request #2248 from pi-hole/fix/revServer_migration
4c4dd88 
Also make <domain> optional in the setupVars.conf migration process
@DL6ER
Restart FTL on change of webserver.headers
a53a357 
Signed-off-by: DL6ER <[email protected]>
@DL6ER
Expose bound-to addresses from CivetWeb to the frontend
af4d1dc 
Signed-off-by: DL6ER <[email protected]>
@DL6ER
Add new CivetWeb patch
2dc36c0 
Signed-off-by: DL6ER <[email protected]>
@DL6ER
Use really bound-to IP addresses in CHAOS TXT local.api.ftl
7dab630 
Signed-off-by: DL6ER <[email protected]>
@DL6ER
Adjust tests
62676f3 
Signed-off-by: DL6ER <[email protected]>
DL6ER and others added 26 commits February 23, 2025 20:06
@DL6ER
Wipe out possibly existing entries in dns.hosts, dns.cnameRecords, an…
7e47e30 
…d dhcp.hosts when importing from a v5 Teleporter file having the corresponding files

Signed-off-by: DL6ER <[email protected]>
@DL6ER
Merge pull request #2258 from pi-hole/tweak/rate_limit_ntp
4e66f43 
Rate-limit internal NTP server
@DL6ER
Merge pull request #2265 from pi-hole/fix/v5_v6_hosts_cnameRecords
22175ec 
Prevent duplicated entries on successive v5 Teleporter importing
@iain-henderson
Simplify checking configurations against environment variables in con…
c6d0b80 
…fig/env.c

Signed-off-by: Iain Henderson <[email protected]>
@DL6ER
Assume DHCP_LEASETIME is in hours if imported from setupVars.conf (e.…
edcc941 
…g., via Teleporter or during migration)

Signed-off-by: DL6ER <[email protected]>
@DL6ER
Merge pull request #2256 from iain-henderson/feature/dev-posix-enviro…
45d0c8a 
…nment

Update config/env.c to accept conventional environment variables in a…
@DL6ER
We should not send any content for HTTP codes 1xx, 204 and 304
6ffd43b 
Signed-off-by: DL6ER <[email protected]>
@DL6ER
Log incorrect env vars
2ce8ff9 
Signed-off-by: DL6ER <[email protected]>
@DL6ER
Explicitly log allowed items
494d27a 
Signed-off-by: DL6ER <[email protected]>
@DL6ER
Data returned by the API for over-time statistics should not return m…
3fe2333 
…ore than specified in webserver.api.maxHistory

Signed-off-by: DL6ER <[email protected]>
@DL6ER
Merge pull request #2272 from pi-hole/fix/delete
1fcb2bb 
We should not send any content for HTTP codes 1xx, 204 and 304
@DL6ER
Merge pull request #2271 from pi-hole/fix/teleporter_v5_leasetime
ad1041e 
Fix DHCP_LEASETIME migration
@DL6ER
Clarify signedness of the overtime constants (unsigned = always posit…
4e5ed22 
…ive)

Signed-off-by: DL6ER <[email protected]>
@DL6ER
Ensure warnings/errors about invalid env vars are only printed once
9857a18 
Signed-off-by: DL6ER <[email protected]>
@DL6ER
Avoid (null) as explanation
ab80387 
Signed-off-by: DL6ER <[email protected]>
@DL6ER
Merge pull request #2273 from pi-hole/new/print_invalid_env
0c91c17 
Print values of env vars if they are invalid
@DL6ER
Merge pull request #2275 from pi-hole/fix/maxHistory
acec7a8 
Fix webserver.api.maxHistory usage in API
@DL6ER
Tweak wording of the history endpoint
a43d078 
Signed-off-by: DL6ER <[email protected]>
@DL6ER
Restart FTL to import more data in case of enlarging webserver.api.ma…
ff9d81c 
…xHistory. The graph would stay mostly empty (until it fills naturally over time), otherweise

Signed-off-by: DL6ER <[email protected]>
@rrobgill
Fix typo in configuration descriptions
f29ed9a 
Signed-off-by: Rob Gill <[email protected]>
@yubiuser
Merge pull request #2280 from rrobgill/typo
0df08a4 
Fix typo in dns option descriptions
@DL6ER
Merge pull request #2285 from pi-hole/fix/maxHistory
a0e4cc9 
Follow-up on #2275
@DL6ER
Fix off-by-one in wildcard SAN checking
0bd03ce 
Signed-off-by: DL6ER <[email protected]>
@tsutsu3
Fix PUT 200 response messages in API docs
c36666a 
Signed-off-by: tsutsu3 <[email protected]>
@DL6ER
Restart FTL on change of webserver.threads
f51f481 
Signed-off-by: DL6ER <[email protected]>
@DL6ER
Merge pull request #2295 from pi-hole/fix/restart_threads
3158465 
Restart FTL on change of webserver.threads
@DL6ER DL6ER added the Release label Feb 26, 2025
@DL6ER DL6ER requested a review from a team February 26, 2025 18:56
DL6ER added 2 commits February 27, 2025 05:24
@DL6ER
Merge pull request #2293 from pi-hole/fix/san_wildcard
0d8251b 
Fix off-by-one in wildcard SAN checking
@DL6ER
Merge pull request #2291 from tsutsu3/fix-api-docs-put
f0a4ac1 
Fix status codes and response messages for PUT in API docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@DL6ER @rrobgill @PromoFaux @bennettmsherman @yubiuser @iain-henderson @MichaIng @tsutsu3