In the corner-case of a user explicitly having configured Pi-hole to …

…NOT listen on lo (because there may be another webserver, etc.), the pihole CLI command may be unable to communicate with the API due to the hard-coded path "localhost". Change this to use the special "pi.hole" host name where interface-dependent replying is already implemented

Signed-off-by: DL6ER <[email protected]>

src/webserver/webserver.c

@@ -281,7 +281,7 @@ unsigned short get_api_string(char **buf, const bool domain)
 	size_t len = 0;
 	// First byte has the length of the first string
 	**buf = 0;
-	const char *domain_str = domain ? config.webserver.domain.v.s : "localhost";
+	const char *domain_str = domain ? config.webserver.domain.v.s : "pi.hole";
 	size_t api_str_size = strlen(domain_str) + 20;
 
 	// Check if the string is too long for the TXT record

test/test_suite.bats

@@ -1179,7 +1179,7 @@
 @test "API addresses reported correctly by CHAOS TXT local.api.ftl" {
   run bash -c 'dig CHAOS TXT local.api.ftl +short @127.0.0.1'
   printf "dig (full): %s\n" "${lines[@]}"
-  [[ ${lines[0]} == '"http://localhost:80/api/" "https://localhost:443/api/"' ]]
+  [[ ${lines[0]} == '"http://pi.hole:80/api/" "https://pi.hole:443/api/"' ]]
 }
 
 @test "API addresses reported by CHAOS TXT api.ftl identical to domain.api.ftl" {