feat: allow customization on readyz and livez config #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2068 +/- ##
==========================================
- Coverage 63.47% 63.46% -0.01%
==========================================
Files 319 320 +1
Lines 29253 29345 +92
==========================================
+ Hits 18568 18624 +56
- Misses 9671 9702 +31
- Partials 1014 1019 +5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
kohlisid
reviewed
Sep 18, 2024
| @@ -253,6 +253,18 @@ func (v Vertex) GetPodSpec(req GetVertexPodSpecReq) (*corev1.PodSpec, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| var readyzInitDeploy, readyzPeriodSeconds, readyzTimeoutSeconds, readyzFailureThreshold int32 = 5, 10, 30, 6 // default values | |||
There was a problem hiding this comment.
Should we store these default numeric values as constants, i see them getting reused in multiple places
Signed-off-by: Derek Wang <[email protected]>
vigith
approved these changes
Sep 19, 2024
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
whynowy
added a commit
that referenced
this pull request
Sep 26, 2024
Signed-off-by: Derek Wang <[email protected]>
SaniyaKalamkar
pushed a commit
to SaniyaKalamkar/numaflow
that referenced
this pull request
Jan 19, 2025
Signed-off-by: Derek Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2066