Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow customization on readyz and livez config #2068

Merged
merged 8 commits into from
Sep 19, 2024
Merged

feat: allow customization on readyz and livez config #2068

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9bdd5d7
feat: allow customzation on readyz and livez config
whynowy Sep 17, 2024
faa5df3
docs
whynowy Sep 17, 2024
b53eb23
.
whynowy Sep 17, 2024
3fd78e8
fix test cases
whynowy Sep 17, 2024
d563a2e
check pods ready
whynowy Sep 17, 2024
f85da6a
contants
whynowy Sep 18, 2024
2a88943
fix port conflict problem
whynowy Sep 19, 2024
cae65ee
nats dep
whynowy Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions api/json-schema/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17939,6 +17939,12 @@
"imagePullPolicy": {
"type": "string"
},
"livenessProbe": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.Probe"
},
"readinessProbe": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.Probe"
},
"resources": {
"$ref": "#/definitions/io.k8s.api.core.v1.ResourceRequirements"
},
Expand Down Expand Up @@ -17972,6 +17978,12 @@
"imagePullPolicy": {
"type": "string"
},
"livenessProbe": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.Probe"
},
"readinessProbe": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.Probe"
},
"resources": {
"$ref": "#/definitions/io.k8s.api.core.v1.ResourceRequirements"
},
Expand Down Expand Up @@ -19739,6 +19751,37 @@
},
"type": "object"
},
"io.numaproj.numaflow.v1alpha1.Probe": {
"description": "Probe is used to customize the configuration for Readiness and Liveness probes.",
"properties": {
"failureThreshold": {
"description": "Minimum consecutive failures for the probe to be considered failed after having succeeded. Defaults to 3. Minimum value is 1.",
"format": "int32",
"type": "integer"
},
"initialDelaySeconds": {
"description": "Number of seconds after the container has started before liveness probes are initiated. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes",
"format": "int32",
"type": "integer"
},
"periodSeconds": {
"description": "How often (in seconds) to perform the probe.",
"format": "int32",
"type": "integer"
},
"successThreshold": {
"description": "Minimum consecutive successes for the probe to be considered successful after having failed. Defaults to 1. Must be 1 for liveness and startup. Minimum value is 1.",
"format": "int32",
"type": "integer"
},
"timeoutSeconds": {
"description": "Number of seconds after which the probe times out. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes",
"format": "int32",
"type": "integer"
}
},
"type": "object"
},
"io.numaproj.numaflow.v1alpha1.RedisBufferService": {
"properties": {
"external": {
Expand Down
43 changes: 43 additions & 0 deletions api/openapi-spec/swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17944,6 +17944,12 @@
"imagePullPolicy": {
"type": "string"
},
"livenessProbe": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.Probe"
},
"readinessProbe": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.Probe"
},
"resources": {
"$ref": "#/definitions/io.k8s.api.core.v1.ResourceRequirements"
},
Expand Down Expand Up @@ -17977,6 +17983,12 @@
"imagePullPolicy": {
"type": "string"
},
"livenessProbe": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.Probe"
},
"readinessProbe": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.Probe"
},
"resources": {
"$ref": "#/definitions/io.k8s.api.core.v1.ResourceRequirements"
},
Expand Down Expand Up @@ -19725,6 +19737,37 @@
}
}
},
"io.numaproj.numaflow.v1alpha1.Probe": {
"description": "Probe is used to customize the configuration for Readiness and Liveness probes.",
"type": "object",
"properties": {
"failureThreshold": {
"description": "Minimum consecutive failures for the probe to be considered failed after having succeeded. Defaults to 3. Minimum value is 1.",
"type": "integer",
"format": "int32"
},
"initialDelaySeconds": {
"description": "Number of seconds after the container has started before liveness probes are initiated. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes",
"type": "integer",
"format": "int32"
},
"periodSeconds": {
"description": "How often (in seconds) to perform the probe.",
"type": "integer",
"format": "int32"
},
"successThreshold": {
"description": "Minimum consecutive successes for the probe to be considered successful after having failed. Defaults to 1. Must be 1 for liveness and startup. Minimum value is 1.",
"type": "integer",
"format": "int32"
},
"timeoutSeconds": {
"description": "Number of seconds after which the probe times out. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes",
"type": "integer",
"format": "int32"
}
}
},
"io.numaproj.numaflow.v1alpha1.RedisBufferService": {
"type": "object",
"properties": {
Expand Down
Loading
Loading