Skip to content

Commit

Permalink
feat: allow customization on readyz and livez config (numaproj#2068)
Browse files Browse the repository at this point in the history
Signed-off-by: Derek Wang <[email protected]>
  • Loading branch information
whynowy authored and SaniyaKalamkar committed Jan 19, 2025
1 parent f196841 commit 6ffc13b
Show file tree
Hide file tree
Showing 40 changed files with 6,463 additions and 597 deletions.
43 changes: 43 additions & 0 deletions api/json-schema/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -17939,6 +17939,12 @@
"imagePullPolicy": {
"type": "string"
},
"livenessProbe": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.Probe"
},
"readinessProbe": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.Probe"
},
"resources": {
"$ref": "#/definitions/io.k8s.api.core.v1.ResourceRequirements"
},
Expand Down Expand Up @@ -17972,6 +17978,12 @@
"imagePullPolicy": {
"type": "string"
},
"livenessProbe": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.Probe"
},
"readinessProbe": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.Probe"
},
"resources": {
"$ref": "#/definitions/io.k8s.api.core.v1.ResourceRequirements"
},
Expand Down Expand Up @@ -19739,6 +19751,37 @@
},
"type": "object"
},
"io.numaproj.numaflow.v1alpha1.Probe": {
"description": "Probe is used to customize the configuration for Readiness and Liveness probes.",
"properties": {
"failureThreshold": {
"description": "Minimum consecutive failures for the probe to be considered failed after having succeeded. Defaults to 3. Minimum value is 1.",
"format": "int32",
"type": "integer"
},
"initialDelaySeconds": {
"description": "Number of seconds after the container has started before liveness probes are initiated. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes",
"format": "int32",
"type": "integer"
},
"periodSeconds": {
"description": "How often (in seconds) to perform the probe.",
"format": "int32",
"type": "integer"
},
"successThreshold": {
"description": "Minimum consecutive successes for the probe to be considered successful after having failed. Defaults to 1. Must be 1 for liveness and startup. Minimum value is 1.",
"format": "int32",
"type": "integer"
},
"timeoutSeconds": {
"description": "Number of seconds after which the probe times out. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes",
"format": "int32",
"type": "integer"
}
},
"type": "object"
},
"io.numaproj.numaflow.v1alpha1.RedisBufferService": {
"properties": {
"external": {
Expand Down
43 changes: 43 additions & 0 deletions api/openapi-spec/swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -17944,6 +17944,12 @@
"imagePullPolicy": {
"type": "string"
},
"livenessProbe": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.Probe"
},
"readinessProbe": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.Probe"
},
"resources": {
"$ref": "#/definitions/io.k8s.api.core.v1.ResourceRequirements"
},
Expand Down Expand Up @@ -17977,6 +17983,12 @@
"imagePullPolicy": {
"type": "string"
},
"livenessProbe": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.Probe"
},
"readinessProbe": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.Probe"
},
"resources": {
"$ref": "#/definitions/io.k8s.api.core.v1.ResourceRequirements"
},
Expand Down Expand Up @@ -19725,6 +19737,37 @@
}
}
},
"io.numaproj.numaflow.v1alpha1.Probe": {
"description": "Probe is used to customize the configuration for Readiness and Liveness probes.",
"type": "object",
"properties": {
"failureThreshold": {
"description": "Minimum consecutive failures for the probe to be considered failed after having succeeded. Defaults to 3. Minimum value is 1.",
"type": "integer",
"format": "int32"
},
"initialDelaySeconds": {
"description": "Number of seconds after the container has started before liveness probes are initiated. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes",
"type": "integer",
"format": "int32"
},
"periodSeconds": {
"description": "How often (in seconds) to perform the probe.",
"type": "integer",
"format": "int32"
},
"successThreshold": {
"description": "Minimum consecutive successes for the probe to be considered successful after having failed. Defaults to 1. Must be 1 for liveness and startup. Minimum value is 1.",
"type": "integer",
"format": "int32"
},
"timeoutSeconds": {
"description": "Number of seconds after which the probe times out. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes",
"type": "integer",
"format": "int32"
}
}
},
"io.numaproj.numaflow.v1alpha1.RedisBufferService": {
"type": "object",
"properties": {
Expand Down
Loading

0 comments on commit 6ffc13b

Please sign in to comment.