Add rust bindings for SGX crypto library #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcape let me know if this is the directory layout you were thinking of. |
remoun
reviewed
May 18, 2022
remoun
reviewed
May 19, 2022
remoun
previously approved these changes
May 19, 2022
nick-mobilecoin
force-pushed
the
feature/move_panic_into_trusted_dir
branch
from
e52ed44 to
853f044
Compare
nick-mobilecoin
force-pushed
the
feature/crypto
branch
from
28c5730 to
0bda4ab
Compare
9 tasks
nick-mobilecoin
changed the base branch from
develop
to
feature/common_build_crate
nick-mobilecoin
force-pushed
the
feature/crypto
branch
from
2f9ceac to
9aaa4e5
Compare
This was referenced Jul 14, 2022
Merged
Merged
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
nick-mobilecoin
force-pushed
the
feature/crypto
branch
from
9aaa4e5 to
48d9ef7
Compare
|
The generated bindings files |
nick-mobilecoin
dismissed
remoun’s stale review
The rebase and refactor doesn't accuratly represent the code that was originally reviewed.
remoun
approved these changes
Jul 15, 2022
nick-mobilecoin
force-pushed
the
feature/common_build_crate
branch
from
bc4ee90 to
136bec0
Compare
nick-mobilecoin
force-pushed
the
feature/crypto
branch
from
f5379a1 to
de6fbb5
Compare
nick-mobilecoin
force-pushed
the
feature/common_build_crate
branch
from
136bec0 to
85cf180
Compare
nick-mobilecoin
force-pushed
the
feature/crypto
branch
from
de6fbb5 to
d8f8d13
Compare
Co-authored-by: Remoun Metyas <[email protected]>
nick-mobilecoin
force-pushed
the
feature/common_build_crate
branch
from
85cf180 to
3f00da6
Compare
nick-mobilecoin
force-pushed
the
feature/crypto
branch
from
d8f8d13 to
c9b82dd
Compare
This was referenced Jul 21, 2022
awygle
approved these changes
Jul 21, 2022
|
Graphite Merge Job Current status: ✅ Merged This pull request was successfully merged as part of a stack. This comment was auto-generated by Graphite. Job Reference: QB8STOU63qtQFHJyhfrd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial rust wrapper to show usage of bindings for SGX crypto library.
This provides the basic bindings to show that the sgx_tcrypto library is linked in and can be executed against. Only one sgx function was provided with an explicit rust wrapper.
The tests currently rely on std
Follow on work will bring in rust wrappers for the rest of the crypto functionality.