Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trts rust interface #6

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Add trts rust interface #6

merged 1 commit into from
Jul 21, 2022

Conversation

nick-mobilecoin
Copy link
Collaborator

Add FFI bindings for the sgx_trts library.

@nick-mobilecoin nick-mobilecoin requested a review from a team May 16, 2022 21:01
remoun
remoun reviewed May 16, 2022
View reviewed changes
Copy link
Contributor

@remoun remoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not clear on what TRTS is. Please document that somewhere in this new crate.

trusted/trts/src/lib.rs Outdated Show resolved Hide resolved
trusted/trts/src/lib.rs Outdated Show resolved Hide resolved
.github/workflows/workspace.yaml Outdated Show resolved Hide resolved
.github/workflows/workspace.yaml Outdated Show resolved Hide resolved
trusted/trts/src/lib.rs Outdated Show resolved Hide resolved
trusted/trts_sys/Cargo.toml Outdated Show resolved Hide resolved
trusted/trts_sys/build.rs Outdated Show resolved Hide resolved
@remoun remoun requested a review from a team May 16, 2022 21:14
remoun
remoun reviewed May 17, 2022
View reviewed changes
trusted/rust-toolchain.toml Show resolved Hide resolved
trusted/trts/src/lib.rs Outdated Show resolved Hide resolved
.github/workflows/workspace.yaml Outdated Show resolved Hide resolved
.github/workflows/workspace.yaml Outdated Show resolved Hide resolved
remoun
remoun reviewed May 17, 2022
View reviewed changes
trusted/trts/src/lib.rs Outdated Show resolved Hide resolved
@remoun remoun requested review from jcape and NotGyro May 18, 2022 01:25
@nick-mobilecoin nick-mobilecoin mentioned this pull request May 19, 2022
Merged
@nick-mobilecoin nick-mobilecoin force-pushed the feature/move_panic_into_trusted_dir branch from e52ed44 to 853f044 Compare May 20, 2022 21:28
Base automatically changed from feature/move_panic_into_trusted_dir to develop May 20, 2022 21:35
@nick-mobilecoin nick-mobilecoin changed the base branch from develop to feature/github_actions July 13, 2022 22:32
This was referenced Jul 13, 2022
Merged
Merged
Merged
@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Jul 13, 2022 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@nick-mobilecoin nick-mobilecoin requested a review from a team July 13, 2022 22:32
@nick-mobilecoin nick-mobilecoin changed the base branch from feature/github_actions to develop July 14, 2022 14:14
@nick-mobilecoin nick-mobilecoin changed the base branch from develop to feature/github_actions July 14, 2022 14:14
This was referenced Jul 14, 2022
Closed
Merged
@nick-mobilecoin nick-mobilecoin force-pushed the feature/github_actions branch 2 times, most recently from 2b15273 to e30482d Compare July 14, 2022 22:05
@nick-mobilecoin nick-mobilecoin mentioned this pull request Jul 15, 2022
Merged
@remoun remoun requested a review from a team July 15, 2022 21:49
@nick-mobilecoin nick-mobilecoin force-pushed the feature/github_actions branch from 05de5d1 to 60acba9 Compare July 15, 2022 22:48
@jcape jcape removed the request for review from a team July 18, 2022 17:27
@nick-mobilecoin nick-mobilecoin force-pushed the feature/github_actions branch from 60acba9 to 158f49b Compare July 20, 2022 20:17
@nick-mobilecoin nick-mobilecoin force-pushed the feature/github_actions branch from 158f49b to 9e3255b Compare July 20, 2022 20:20
Base automatically changed from feature/github_actions to develop July 20, 2022 21:08
This was referenced Jul 21, 2022
Merged
Merged
awygle
awygle approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@awygle awygle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nick-mobilecoin nick-mobilecoin merged commit 46a0631 into develop Jul 21, 2022
@nick-mobilecoin nick-mobilecoin deleted the feature/trts branch July 21, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remoun remoun remoun approved these changes

@awygle awygle awygle approved these changes

@jcape jcape Awaiting requested review from jcape

@NotGyro NotGyro Awaiting requested review from NotGyro

Assignees

@nick-mobilecoin nick-mobilecoin

Labels
None yet
Projects
Blockchain Core
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nick-mobilecoin @remoun @awygle