Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github actions now check for lock file changes #31

Merged
merged 1 commit into from
Jul 25, 2022
Merged

github actions now check for lock file changes #31

merged 1 commit into from
Jul 25, 2022

Conversation

nick-mobilecoin
Copy link
Collaborator

No description provided.

@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Jul 21, 2022 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@nick-mobilecoin nick-mobilecoin force-pushed the feature/check_cargo_lock branch from 64ad9e6 to 61958a8 Compare July 21, 2022 14:52
@nick-mobilecoin nick-mobilecoin changed the base branch from develop to feature/better_no_std July 21, 2022 15:03
@nick-mobilecoin nick-mobilecoin force-pushed the feature/check_cargo_lock branch from 61958a8 to a29153c Compare July 21, 2022 15:03
This was referenced Jul 21, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@nick-mobilecoin
github actions now check for lock file changes
c40e4a1 
Previously a Cargo.lock file could change during CI runs, hiding package
updates.  Now the `--locked` flag is passed to the CI checks resulting
in an error if a Cargo.lock file changes.
@nick-mobilecoin nick-mobilecoin force-pushed the feature/check_cargo_lock branch from a29153c to c40e4a1 Compare July 21, 2022 15:12
awygle
awygle approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@awygle awygle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nick-mobilecoin nick-mobilecoin self-assigned this Jul 22, 2022
@jcape jcape self-requested a review July 22, 2022 17:24
@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Jul 25, 2022 •
edited
Loading

Graphite Merge Job

Current status: ✅ Merged

This pull request was successfully merged as part of a stack.

This comment was auto-generated by Graphite.

Job Reference: tCEFOsXmIVR1PvpWOGXr

Base automatically changed from feature/better_no_std to develop July 25, 2022 21:38
@nick-mobilecoin nick-mobilecoin merged commit 93d7658 into develop Jul 25, 2022
@nick-mobilecoin nick-mobilecoin deleted the feature/check_cargo_lock branch July 25, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcape jcape jcape approved these changes

@awygle awygle awygle approved these changes

Assignees

@nick-mobilecoin nick-mobilecoin

Labels
None yet
Projects
Blockchain Core
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nick-mobilecoin @jcape @awygle