CI improvements #264
Merged
CI improvements #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit features several CI improvements: - Clearer naming of CI files, pipelines, and jobs. - Adds "website-test.yml" to test website changes on PRs. - Removes duplicative tests on `main` after equivalent tests on PRs, given that PRs can only merge with passing tests. Signed-off-by: Andrew Lilley Brinker <[email protected]>
alilleybrinker
force-pushed
the
alilleybrinker/site-ci
branch
from
2573775 to
3977498
Compare
alilleybrinker
requested review from
a team and
patrickjcasey
and removed request for
a team
mchernicoff
approved these changes
Aug 9, 2024
alilleybrinker
added a commit
that referenced
this pull request
Aug 9, 2024
The website deploy CI job was quietly broken by #264, and this commit fixes it by ensuring the job dependency name matches the earlier renamed build job. It also gives the "Website Deploy" and "Website Test" workflows distinct names so they're clearly different in the GitHub UI. Signed-off-by: Andrew Lilley Brinker <[email protected]>
mchernicoff
pushed a commit
that referenced
this pull request
Aug 9, 2024
The website deploy CI job was quietly broken by #264, and this commit fixes it by ensuring the job dependency name matches the earlier renamed build job. It also gives the "Website Deploy" and "Website Test" workflows distinct names so they're clearly different in the GitHub UI. Signed-off-by: Andrew Lilley Brinker <[email protected]>
|
I think there is a caching issue caused by no longer running the tests on pushes to GitHub Actions isolates caches created for Pull Requests, so they cannot be used when building other Pull Requests (except when the new PR is based on another PR that had a cache) or the |
|
Oh, how annoying. Okay, want to open a PR to run on main again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit features several CI improvements:
mainafter equivalent tests on PRs, given that PRs can only merge with passing tests.