fix(build): Always run tests on main to create reusable caches #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #264 changed the build settings so that tests would not be run on all pushes to the
main
branch.Unfortunately, while it seems wasteful to do redundant builds, this has the consequence of preventing re-use of build caches.
The reason is that build caches created for Pull Requests are isolated from other PRs (except those based on that PR) and the
main
branch. Build caches created formain
can be re-used in PR builds, which is what we want.GitHub Actions docs on re-use of build caches
The good news is that this should save build time overall. It should also reduce churn in the storage of caches: Most of the time, caches made for
main
can be reused in PR builds, which means that no new caches need to be created at all for PRs that don't changeCargo.toml
orCargo.lock
.