Skip to content

Commit

Permalink
fix: Fix broken website deploy CI job
Browse files Browse the repository at this point in the history
The website deploy CI job was quietly broken by #264, and this commit
fixes it by ensuring the job dependency name matches the earlier renamed
build job.

It also gives the "Website Deploy" and "Website Test" workflows distinct
names so they're clearly different in the GitHub UI.

Signed-off-by: Andrew Lilley Brinker <[email protected]>
  • Loading branch information
alilleybrinker committed Aug 9, 2024
1 parent bf2a68a commit a91b95b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/commits.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Commits
name: Commit Checks

on:
pull_request:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/website-deploy.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Website
name: Website Deploy

# Runs on pushed to the default branch but can also be
# run manually from the GitHub Actions page.
Expand Down Expand Up @@ -86,7 +86,7 @@ jobs:
name: github-pages
url: ${{ steps.deployment.outputs.page_url }}
runs-on: ubuntu-latest
needs: build
needs: website-build
steps:
- name: Deploy to GitHub Pages
id: deployment
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/website-test.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Website
name: Website Test

# Run when PRs would modify the site code.
on:
Expand Down

0 comments on commit a91b95b

Please sign in to comment.