Implement several minor bug fixes (matplotlib 3.8+, GitHub actions, remove obsolete features) #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcpy/examples/diagnostics/compare_diags.py - Import rename_and_flip_gchp_rst_vars function from gcpy.util gcpy/examples/diagnostics/compare_diags.yml - Added "n_cores: -1" to specify maximum parallelization CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
docs/environment_files/environment.yml - Now request matplotlib 3.8 or later. This will ensure that GCPy will not encounter issues caused by older matplotlib versions. Signed-off-by: Bob Yantosca <[email protected]>
gcpy/examples/timeseries/mda8_o3_timeseries.py - Now removed (as per feature request #282 CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
.github/workflows/pylint.yml - Now removed. The Pylint GitHub action would always fail due to non-conforming code. .github/workflows/stale.yml - Now run the stale action at midnight UTC on the 1st of each month - Now remove stale issues after 30 days of being marked - Now do not remove stale PRs CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
yantosca
added
topic: Structural Modifications
gcpy/examples/timeseries/__init__.py - Removed reference to mda8_o3_timeseries, which was removed in the prior commit. This was causing an import error. Now fixed. Signed-off-by: Bob Yantosca <[email protected]>
yantosca
changed the title
This merge brings the recent GCPy 1.4.2 version into the bugfix/compare_diags branch, in order to keep this branch up-to-date. Signed-off-by: Bob Yantosca <[email protected]>
yantosca
changed the title
yantosca
added a commit
that referenced
this pull request
Feb 6, 2024
This merge brings PR #283 (Split python packages needed for RTD documentation builds out of the GCPy conda environment and into a separate environment; remove awscli, by @yantosca) This PR removes awscli from the GCPy Mamba/Conda environment, since that prevents installation from PyPi. Also we have moved the packages that are needed to build ReadTheDocs from the GCPy environment into a separate Mamba/Conda environment. This allows us to update those packages to a more recent Python version while keeping the GCPy environment pegged at Python 3.9.18. Signed-off-by: Bob Yantosca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Confirm you have reviewed the following documentation
Describe the update
This PR implements several minor bug fixes that can go into GCPy 1.4.2, namely:
Import function
rename_and_flip_gchp_rst_varsfunction fromgcpy/util.pyintogcpy/examples/diagnostics/compare_diags.py(in commit 0b9b342)Add
n_cores: -1to gcpy/examples/diagnostics/compare_diags.yml` to specify maximum parallelization (in commit (0b9b342)Now require
matplotlib>=3.8indocs_environment_files/environment.yml(in commit c83f866).Removed obsolete example script
gcpy/examples/plotting/mda8_o3_timeseries.py(in commit 43c7695). This addresses the problem raised in GCPy 1.4.1 usages of seaborn-talk is deprecated in older matplotlib versions #282.Removed the
PylintGitHub action (in commit 5c53c3e) This would always fail due to non-conforming code.Updated the
staleGitHub action to run at midnight UTC on the first of each month (in commit 5c53c3e). Also never mark PRs as staleExpected changes
compare_diags.py.failedby PylintRelated Github Issue(s)