Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCPy 1.4.1 usages of seaborn-talk is deprecated in older matplotlib versions #282

Closed
lizziel opened this issue Jan 18, 2024 · 2 comments · Fixed by #283
Closed

GCPy 1.4.1 usages of seaborn-talk is deprecated in older matplotlib versions #282

lizziel opened this issue Jan 18, 2024 · 2 comments · Fixed by #283
Assignees
Labels
category: Bug Something isn't working topic: Colors and Display Issues pertaining to color scales or other display issues topic: Dependencies Pull requests that update a dependency file

Comments

@lizziel
Copy link
Contributor

lizziel commented Jan 18, 2024

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Description of your issue or question

I recently created a new GCPy environment to use with GCPy 1.4.1. The environment.yml file does not specify version for matplotlib and the version retrieved using my package manager was 3.3.2. This version is not compatible with the seaborn-talk implementation in GCPy. I suggest specifying a minimum version of matplotlib within the environment.yml file.

Incidentally, I got around this issue by removing the examples/timeseries/ files in GCPy. These examples are general python examples and are not documented on GCPy's ReadTheDocs. I suggest deleting these as they introduce potential for package conflicts and may also simply get out-of-date.

yantosca added a commit that referenced this issue Jan 23, 2024
gcpy/examples/timeseries/mda8_o3_timeseries.py
- Now removed (as per feature request #282

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <[email protected]>
@lizziel lizziel added the topic: Dependencies Pull requests that update a dependency file label Jan 25, 2024
@yantosca
Copy link
Contributor

This will be fixed by PR #283

@yantosca yantosca added the category: Bug Something isn't working label Jan 25, 2024
@yantosca yantosca self-assigned this Jan 25, 2024
@yantosca yantosca added the topic: Colors and Display Issues pertaining to color scales or other display issues label Jan 26, 2024
@yantosca
Copy link
Contributor

yantosca commented Feb 8, 2024

We can close this since PR #283 has been merged.

@yantosca yantosca closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Something isn't working topic: Colors and Display Issues pertaining to color scales or other display issues topic: Dependencies Pull requests that update a dependency file
Projects
None yet
2 participants