Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement several minor bug fixes (matplotlib 3.8+, GitHub actions, remove obsolete features) #283

Merged
merged 6 commits into from
Feb 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions .github/workflows/pylint.yml

This file was deleted.

17 changes: 11 additions & 6 deletions .github/workflows/stale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ name: Mark stale issues and pull requests

on:
schedule:
- cron: '32 22 * * *'
# Job will run at midnight on the 1st of each month (POSIX time syntax)
- cron: '0 0 1 * *'

jobs:
stale:

runs-on: ubuntu-latest
permissions:
issues: write
Expand All @@ -21,7 +21,12 @@ jobs:
- uses: actions/stale@v5
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
stale-issue-message: 'Stale issue message'
stale-pr-message: 'Stale pull request message'
stale-issue-label: 'no-issue-activity'
stale-pr-label: 'no-pr-activity'
# Stale issue settings
days-before-issue-stale: 30
days-before-issue-close: 30
stale-issue-label: 'stale'
stale-issue-message: 'This issue is stale because it has been open for 30 days with no activity.'
close-issue-message: "This issue was closed because it has been inactive for 30 days since being marked as stale."
# Never mark PRs as stale
days-before-pr-stale: -1
days-before-pr-close: -1
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,19 @@ All notable changes to GCPy will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased] - TBD
### Changed
- Now require `matplotlib>=3.8` in `docs/environment_files/environment.yml`
- Now run the `stale` GitHub action at 00:00 UTC on the 1st of each month

### Fixed
- Import error in `gcpy/examples/diagnostics/compare_diags.py`
- Added missing `n_cores` to `gcpy/examples/diagnostics/compare_diags.yml`

### Removed
- Example script `gcpy/examples/plotting/mda8_o3_timeseries.py`
- Removed `Pylint` GitHub action

## [1.4.2] - 2024-01-26
### Added
- Example script `create_test_plot.py`, which can be used to check that GCPy has been installed properly
Expand Down
6 changes: 3 additions & 3 deletions gcpy/examples/diagnostics/compare_diags.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import warnings
import numpy as np
from gcpy.util import add_missing_variables, compare_varnames, \
dataset_reader, read_config_file
dataset_reader, read_config_file, rename_and_flip_gchp_rst_vars
from gcpy.constants import skip_these_vars
from gcpy.plot.compare_single_level import compare_single_level
from gcpy.plot.compare_zonal_mean import compare_zonal_mean
Expand Down Expand Up @@ -109,8 +109,8 @@ def read_data(config):
# If the data is from a GCHP restart file, rename variables and
# flip levels to match the GEOS-Chem Classic naming and level
# conventions. Otherwise no changes will be made.
refdata = util.rename_and_flip_gchp_rst_vars(refdata)
devdata = util.rename_and_flip_gchp_rst_vars(devdata)
refdata = rename_and_flip_gchp_rst_vars(refdata)
devdata = rename_and_flip_gchp_rst_vars(devdata)

# Define dictionary for return
data = {
Expand Down
1 change: 1 addition & 0 deletions gcpy/examples/diagnostics/compare_diags.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,4 @@ options:
filename: ''
skip_small_diffs: True
small_diff_threshold: 0.0000
n_cores: -1
1 change: 0 additions & 1 deletion gcpy/examples/timeseries/__init__.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
"""
GCPy import script
"""
from .mda8_o3_timeseries import *
from .plot_timeseries import *

84 changes: 0 additions & 84 deletions gcpy/examples/timeseries/mda8_o3_timeseries.py

This file was deleted.