Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom debugging functions #50

Conversation

mdeitersen
Copy link
Contributor

@mdeitersen mdeitersen commented Jan 20, 2024

Closes #7

  • Seperated subtree managing logic from DebugManager and put it into its own class
  • DebugManager now only has the purpose to collect node diagnostic data. Removed all other functionalities.

The following has to be adapted in the interface:

  • DebugInfo.msg is replaced by SubtreeInfo.msg to publish the subtree states
  • SetExecutionMode.srv and DebugSettings.msg to define the settings for recording node diagnostics and publishing subtrees are replaced by the services ~/debug/set_collect_node_diagnostics and ~/debug/set_publish_subtrees services

Closes #9

  • added missing copyright headers

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2024

Codecov Report

Attention: 94 lines in your changes are missing coverage. Please review.

Comparison is base (870f4a2) 32.91% compared to head (b5e72f4) 33.01%.

Files Patch % Lines
ros_bt_py/src/ros_bt_py/tree_manager.py 9.09% 40 Missing ⚠️
ros_bt_py/src/ros_bt_py/debug_manager.py 13.33% 39 Missing ⚠️
ros_bt_py/src/ros_bt_py/ros_nodes/subtree.py 9.09% 10 Missing ⚠️
ros_bt_py/src/ros_bt_py/tree_node.py 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   32.91%   33.01%   +0.09%     
==========================================
  Files          37       38       +1     
  Lines        5398     5352      -46     
  Branches     1248     1229      -19     
==========================================
- Hits         1777     1767      -10     
+ Misses       3553     3519      -34     
+ Partials       68       66       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ros_bt_py/src/ros_bt_py/subtree_manager.py Show resolved Hide resolved
ros_bt_py/src/ros_bt_py/tree_manager.py Outdated Show resolved Hide resolved
@Oberacda Oberacda added enhancement New feature or request Core Library Issues concerning the core BT library. Medium Priority labels Jan 26, 2024
@Oberacda Oberacda added this to the First ROS2 Release milestone Jan 26, 2024
@Oberacda Oberacda changed the base branch from main to dev February 22, 2024 13:37
@Oberacda Oberacda changed the base branch from dev to fb_remove_debug_code April 5, 2024 12:07
@Oberacda Oberacda merged commit a0c177f into fzi-forschungszentrum-informatik:fb_remove_debug_code Apr 5, 2024
3 checks passed
@Oberacda Oberacda mentioned this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Library Issues concerning the core BT library. enhancement New feature or request Medium Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for helper functions Remove custom debugging functions
3 participants