-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove custom debugging functions #50
Merged
Oberacda
merged 12 commits into
fzi-forschungszentrum-informatik:fb_remove_debug_code
from
mdeitersen:remove_custom_debugging_functions
Apr 5, 2024
Merged
Remove custom debugging functions #50
Oberacda
merged 12 commits into
fzi-forschungszentrum-informatik:fb_remove_debug_code
from
mdeitersen:remove_custom_debugging_functions
Apr 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DebugManager and publish_subtrees in SubtreeManager with two seperate services
mdeitersen
commented
Jan 20, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 32.91% 33.01% +0.09%
==========================================
Files 37 38 +1
Lines 5398 5352 -46
Branches 1248 1229 -19
==========================================
- Hits 1777 1767 -10
+ Misses 3553 3519 -34
+ Partials 68 66 -2 ☔ View full report in Codecov by Sentry. |
Oberacda
requested changes
Jan 23, 2024
Oberacda
approved these changes
Jan 26, 2024
a0c177f
into
fzi-forschungszentrum-informatik:fb_remove_debug_code
3 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Core Library
Issues concerning the core BT library.
enhancement
New feature or request
Medium Priority
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7
The following has to be adapted in the interface:
SetExecutionMode.srv
andDebugSettings.msg
to define the settings for recording node diagnostics and publishing subtrees are replaced by the services~/debug/set_collect_node_diagnostics
and~/debug/set_publish_subtrees
servicesCloses #9