Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug code #78

Merged
merged 21 commits into from
Jul 10, 2024
Merged

Remove debug code #78

merged 21 commits into from
Jul 10, 2024

Conversation

Oberacda
Copy link
Contributor

@Oberacda Oberacda commented Apr 5, 2024

Merge changes to library and web-gui for removing debug functionality.
Closes #7 #9
Related to #50

@Oberacda Oberacda self-assigned this Apr 5, 2024
@Oberacda Oberacda requested a review from a team April 5, 2024 13:10
@Oberacda Oberacda added this to the First ROS2 Release milestone Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

Test Results

  3 files   -   7    3 suites   - 7   41s ⏱️ +14s
202 tests ±  0  202 ✅ ±  0  0 💤 ±0  0 ❌ ±0 
591 runs  +187  591 ✅ +187  0 💤 ±0  0 ❌ ±0 

Results for commit 6b3e88a. ± Comparison against base commit e82d324.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 48.22006% with 160 lines in your changes missing coverage. Please review.

Project coverage is 50.92%. Comparing base (e82d324) to head (6b3e88a).

Files Patch % Lines
ros_bt_py/ros_bt_py/tree_manager.py 9.21% 69 Missing ⚠️
ros_bt_py/ros_bt_py/debug_manager.py 13.33% 39 Missing ⚠️
ros_bt_py/ros_bt_py/ros_nodes/subtree.py 10.71% 25 Missing ⚠️
ros_bt_py/ros_bt_py/node.py 70.45% 10 Missing and 3 partials ⚠️
ros_bt_py/ros_bt_py/tree_node.py 26.66% 11 Missing ⚠️
ros_bt_py/ros_bt_py/nodes/constant.py 0.00% 2 Missing ⚠️
ros_bt_py/ros_bt_py/ros_nodes/service.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev      #78       +/-   ##
===========================================
+ Coverage   33.85%   50.92%   +17.06%     
===========================================
  Files          37       58       +21     
  Lines        5464     7348     +1884     
  Branches     1252     1604      +352     
===========================================
+ Hits         1850     3742     +1892     
+ Misses       3554     3540       -14     
- Partials       60       66        +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Oberacda Oberacda merged commit bf3fea0 into dev Jul 10, 2024
9 checks passed
@Oberacda Oberacda deleted the fb_remove_debug_code branch July 10, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants