feat: metric to trim flanking whitespace

Fixes #216
fulcrumgenomics · Jan 28, 2025 · 6315fbd · 6315fbd
1 parent f1f89e9
commit 6315fbd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/fgpyo/util/metric.py b/fgpyo/util/metric.py
@@ -353,11 +353,11 @@ def format_value(cls, value: Any) -> str:  # noqa: C901
                     + "}"
                 )
         elif isinstance(value, float):
-            return str(round(value, 5))
+            return str(round(value, 5)).strip()
         elif value is None:
             return ""
         else:
-            return str(value)
+            return str(value).strip()
 
     @classmethod
     def to_list(cls, value: str) -> List[Any]:

diff --git a/tests/fgpyo/util/test_metric.py b/tests/fgpyo/util/test_metric.py
@@ -403,6 +403,11 @@ def test_metric_values(data_and_classes: DataBuilder) -> None:
     assert list(data_and_classes.Person(name="name", age=42).values()) == ["name", 42]
 
 
+@pytest.mark.parametrize("data_and_classes", (attr_data_and_classes, dataclasses_data_and_classes))
+def test_metric_whitespace_padded_strip(data_and_classes: DataBuilder) -> None:
+    assert list(data_and_classes.Person(name=" John Doe  \t ", age=42).values()) == ["John Doe", 42]
+
+
 @pytest.mark.parametrize("data_and_classes", (attr_data_and_classes, dataclasses_data_and_classes))
 def test_metric_items(data_and_classes: DataBuilder) -> None:
     """`metric.items()` should return a list of (key, value) tuples."""