Update variables, cleanup, remove {es} override
#196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
leemthompo
commented
Nov 14, 2024
| @@ -11,7 +11,6 @@ include::{asciidoc-dir}/../../shared/attributes.asciidoc[] | |||
| :sec-badge: <<what-is-security-serverless,image:images/sec-badge.svg[Security]>> | |||
|
|
|||
| // The values of these attributes are different in stateful vs serverless | |||
| :es: Elasticsearch Serverless | |||
There was a problem hiding this comment.
This is the important change for Elasticsearch writers, to continue to be able to use ye olde {es} for plain olde Elasticsearch
leemthompo
commented
Nov 14, 2024
| * **{es}**: Build powerful applications and search experiences using a rich ecosystem of vector search capabilities, APIs, and libraries. | ||
| * **Elastic {observability}**: Monitor your own platforms and services using powerful machine learning and analytics tools with your logs, metrics, traces, and APM data. | ||
| * **{es-serverless}**: Build powerful applications and search experiences using a rich ecosystem of vector search capabilities, APIs, and libraries. | ||
| * **{observability}**: Monitor your own platforms and services using powerful machine learning and analytics tools with your logs, metrics, traces, and APM data. |
lcawl
reviewed
Nov 14, 2024
lcawl
reviewed
Nov 14, 2024
lcawl
previously approved these changes
Nov 14, 2024
Co-authored-by: Lisa Cawley <[email protected]>
georgewallace
approved these changes
Nov 15, 2024
|
Unfortunately I made the last change so someone else needs to approve now. :( |
Thanks @georgewallace! |
georgewallace
pushed a commit
to georgewallace/docs-content
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @colleenmcginnis
tl;dr for future reference
{serverless-full}= Elastic Cloud Serverless{es-serverless}= Elasticsearch Serverless{es}= ElasticsearchCaveat lector
I'm 93% sure this didn't fix 100% of everything, but it's probably a fine start.
Preview
Feast your eyes on #196 (comment) iff CI goes green