Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banners noting that serverless clients are serverless only #198

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

marciw
Copy link
Contributor

@marciw marciw commented Nov 14, 2024

For Serverless GA: Fix #80 by adding banners to serverless client docs.

Note: These won't look right until #196 is merged to fix the {es} variable -- for example:

Before #196 is merged:
Screenshot 2024-11-17 at 9 05 34 AM

After #196 is merged:
Screenshot 2024-11-17 at 9 05 59 AM

Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@marciw marciw marked this pull request as ready for review November 17, 2024 14:13
@marciw marciw requested a review from a team as a code owner November 17, 2024 14:13
@marciw marciw changed the title Add banners noting serverless clients are serverless only Add banners noting that serverless clients are serverless only Nov 17, 2024
leemthompo
leemthompo previously approved these changes Nov 18, 2024
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(There are git conflicts so I guess we'll have to reapprove 😠 )

@leemthompo leemthompo merged commit 66b29cc into elastic:main Nov 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants